Reword fips to fips-distribution to make purpose clear (#7878)

* Reword fips to fips-distribution to make purpose clear

* Fix unit test

Author: michel-laterman

internal/pkg/release/version.go

@@ -116,7 +116,7 @@ func (v VersionInfo) String() string {
 	sb.WriteString(" (build: ")
 	sb.WriteString(v.Commit)
 	if v.FIPSDistribution {
-		sb.WriteString(" fips: true")
+		sb.WriteString(" fips-distribution: true")
 	}
 	sb.WriteString(" at ")
 	sb.WriteString(v.BuildTime.Format("2006-01-02 15:04:05 -0700 MST"))

internal/pkg/release/version_test.go

@@ -76,9 +76,9 @@ func TestVersion(t *testing.T) {
 func Test_VersionInfo_WithFIPS(t *testing.T) {
 	info := Info()
 	info.FIPSDistribution = false
-	assert.NotContains(t, info.String(), "fips:", "found fips indicator")
+	assert.NotContains(t, info.String(), "fips-distribution:", "found fips indicator")
 	info.FIPSDistribution = true
-	assert.Contains(t, info.String(), "fips: true", "did not find fips indicator")
+	assert.Contains(t, info.String(), "fips-distribution: true", "did not find fips indicator")
 }
 
 func TestFIPS(t *testing.T) {