Skip to content

Support proxy_url on otel translation logic #10454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 15, 2025
Merged

Support proxy_url on otel translation logic #10454

merged 4 commits into from
Oct 15, 2025

Conversation

khushijain21
Copy link
Contributor

@khushijain21 khushijain21 commented Oct 9, 2025 •
edited
Loading

What does this PR do?

This PR handles conversion logic for proxy_url

Why is it important?

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

How to test this PR locally

Related issues

@khushijain21 khushijain21 requested a review from a team as a code owner October 9, 2025 13:55
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 9, 2025

This pull request does not have a backport label. Could you fix it @khushijain21? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@khushijain21 khushijain21 added skip-changelog backport-8.19 Automated backport to the 8.19 branch backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches labels Oct 9, 2025
@khushijain21 khushijain21 requested a review from swiatekm October 9, 2025 13:59
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Oct 9, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

blakerouse
blakerouse requested changes Oct 9, 2025
View reviewed changes
@elasticmachine
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @khushijain21

@khushijain21 khushijain21 enabled auto-merge (squash) October 10, 2025 10:56
@cmacknz
Copy link
Member

cmacknz commented Oct 10, 2025

@blakerouse can you re-review? Proxy config won't work with beats receivers without this one going in and your suggestion was applied :)

blakerouse
blakerouse approved these changes Oct 15, 2025
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for applying my suggestion.

@khushijain21 khushijain21 merged commit 0e53334 into elastic:main Oct 15, 2025
21 checks passed
@github-actions GitHub Actions
Copy link
Contributor

@Mergifyio backport 9.0 9.1 9.2

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 15, 2025 •
edited
Loading

backport 9.0 9.1 9.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 15, 2025
@khushijain21 @mergify
Support proxy_url on otel translation logic (#10454)
f269190 
* Support proxy_url on otel translation logic

* address comments

(cherry picked from commit 0e53334)

# Conflicts:
#	internal/pkg/otel/translate/output_elasticsearch.go
mergify bot pushed a commit that referenced this pull request Oct 15, 2025
@khushijain21 @mergify
Support proxy_url on otel translation logic (#10454)
2a975fc 
* Support proxy_url on otel translation logic

* address comments

(cherry picked from commit 0e53334)

# Conflicts:
#	internal/pkg/otel/configtranslate/otelconfig.go
#	internal/pkg/otel/translate/otelconfig_test.go
#	internal/pkg/otel/translate/output_elasticsearch.go
@mergify mergify bot mentioned this pull request Oct 15, 2025
Open
8 tasks
mergify bot pushed a commit that referenced this pull request Oct 15, 2025
@khushijain21 @mergify
Support proxy_url on otel translation logic (#10454)
707a957 
* Support proxy_url on otel translation logic

* address comments

(cherry picked from commit 0e53334)

# Conflicts:
#	internal/pkg/otel/translate/output_elasticsearch.go
@mergify mergify bot mentioned this pull request Oct 15, 2025
Open
8 tasks
@mergify mergify bot mentioned this pull request Oct 15, 2025
Open
8 tasks
mergify bot pushed a commit that referenced this pull request Oct 15, 2025
@khushijain21 @mergify
Support proxy_url on otel translation logic (#10454)
39b4889 
* Support proxy_url on otel translation logic

* address comments

(cherry picked from commit 0e53334)
@mergify mergify bot mentioned this pull request Oct 15, 2025
Merged
8 tasks
cmacknz pushed a commit that referenced this pull request Oct 15, 2025
@mergify @khushijain21
Support proxy_url on otel translation logic (#10454) (#10592)
224eac8 
* Support proxy_url on otel translation logic

* address comments

(cherry picked from commit 0e53334)

Co-authored-by: Khushi Jain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakerouse blakerouse blakerouse approved these changes

@swiatekm swiatekm swiatekm approved these changes

@kaanyalti kaanyalti Awaiting requested review from kaanyalti kaanyalti is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@khushijain21 khushijain21

Labels

backport-8.19 Automated backport to the 8.19 branch backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[beats receivers] beatsauth extension used in translation doesn't understand the proxy_url type of type *url.URL

6 participants

@khushijain21 @elasticmachine @cmacknz @blakerouse @swiatekm @pierrehilbert