Skip to content

Commit 5b07bb8

Browse files
committed
review feedback nicer code
1 parent 17da1e4 commit 5b07bb8

File tree

1 file changed

+12
-10
lines changed

1 file changed

+12
-10
lines changed

custom/src/main/java/co/elastic/otel/dynamicconfig/CentralConfig.java

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,12 @@
2525
import io.opentelemetry.sdk.trace.SdkTracerProviderBuilder;
2626
import java.text.MessageFormat;
2727
import java.time.Duration;
28-
import java.util.HashMap;
2928
import java.util.HashSet;
3029
import java.util.Map;
3130
import java.util.Set;
3231
import java.util.logging.Logger;
32+
import java.util.stream.Collectors;
33+
import java.util.stream.Stream;
3334

3435
public class CentralConfig {
3536
private static final Logger logger = Logger.getLogger(CentralConfig.class.getName());
@@ -98,18 +99,19 @@ private static String getServiceName(ConfigProperties properties) {
9899
}
99100

100101
public static class Configs {
101-
private static final Map<String, ConfigOption> configNameToConfig = new HashMap<>();
102+
private static final Map<String, ConfigOption> configNameToConfig;
102103
private static final Set<String> currentNonDefaultConfigsApplied = new HashSet<>();
103104

104105
static {
105-
ConfigOption option;
106-
configNameToConfig.put((option = new SendLogs()).getConfigName(), option);
107-
configNameToConfig.put((option = new SendMetrics()).getConfigName(), option);
108-
configNameToConfig.put((option = new SendTraces()).getConfigName(), option);
109-
configNameToConfig.put(
110-
(option = new DeactivateAllInstrumentations()).getConfigName(), option);
111-
configNameToConfig.put((option = new DeactivateInstrumentations()).getConfigName(), option);
112-
configNameToConfig.put((option = new LoggingLevel()).getConfigName(), option);
106+
configNameToConfig =
107+
Stream.of(
108+
new SendLogs(),
109+
new SendMetrics(),
110+
new SendTraces(),
111+
new DeactivateAllInstrumentations(),
112+
new DeactivateInstrumentations(),
113+
new LoggingLevel())
114+
.collect(Collectors.toMap(ConfigOption::getConfigName, option -> option));
113115
}
114116

115117
public static synchronized void applyConfigurations(Map<String, String> configuration) {

0 commit comments

Comments
 (0)