Skip to content

Commit 816e973

Browse files
committed
make test more generic and easier to extend
1 parent 2110fb2 commit 816e973

File tree

1 file changed

+21
-14
lines changed

1 file changed

+21
-14
lines changed

resources/src/test/java/co/elastic/otel/resources/ResourcesAutoConfigurationTest.java

Lines changed: 21 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -20,53 +20,60 @@
2020

2121
import static org.assertj.core.api.Assertions.assertThat;
2222

23+
import io.opentelemetry.instrumentation.resources.ResourceProviderPropertiesCustomizer;
2324
import io.opentelemetry.sdk.autoconfigure.spi.internal.DefaultConfigProperties;
25+
import java.lang.reflect.Field;
26+
import java.util.Arrays;
2427
import java.util.Collections;
2528
import java.util.HashMap;
29+
import java.util.List;
2630
import java.util.Map;
2731
import org.junit.jupiter.api.Test;
2832

2933
class ResourcesAutoConfigurationTest {
3034

31-
public static final String GCP_ENABLED = "otel.resource.providers.gcp.enabled";
32-
public static final String AWS_ENABLED = "otel.resource.providers.aws.enabled";
33-
public static final String AZURE_ENABLED = "otel.resource.providers.azure.enabled";
35+
private static final List<String> LIST = Arrays.asList(
36+
config("gcp"),
37+
config("aws"),
38+
config("azure"));
39+
40+
private static String config(String provider) {
41+
return String.format("otel.resource.providers.%s.enabled", provider);
42+
}
3443

3544
@Test
3645
void elastic_defaults() {
3746
// default everything should be enabled
3847

3948
Map<String, String> explicitConfig = Collections.emptyMap();
4049
Map<String, String> expectedResult = new HashMap<>();
41-
expectedResult.put(GCP_ENABLED, "true");
42-
expectedResult.put(AWS_ENABLED, "true");
43-
expectedResult.put(AZURE_ENABLED, "true");
50+
51+
LIST.forEach(v -> expectedResult.put(v, "true"));
4452

4553
testConfig(explicitConfig, expectedResult);
4654
}
4755

4856
@Test
4957
void explicitly_enabled() {
5058
Map<String, String> explicitConfig = new HashMap<>();
51-
explicitConfig.put(GCP_ENABLED, "true");
59+
explicitConfig.put(LIST.get(0), "true");
5260

5361
Map<String, String> expectedResult = new HashMap<>();
54-
expectedResult.put(GCP_ENABLED, "true");
55-
expectedResult.put(AWS_ENABLED, "true");
56-
expectedResult.put(AZURE_ENABLED, "true");
62+
LIST.forEach(v -> expectedResult.put(v, "true"));
5763

5864
testConfig(explicitConfig, expectedResult);
5965
}
6066

6167
@Test
6268
void explicitly_disabled() {
6369
Map<String, String> explicitConfig = new HashMap<>();
64-
explicitConfig.put(GCP_ENABLED, "false");
70+
explicitConfig.put(LIST.get(0), "false");
6571

6672
Map<String, String> expectedResult = new HashMap<>();
67-
expectedResult.put(GCP_ENABLED, "false");
68-
expectedResult.put(AWS_ENABLED, "true");
69-
expectedResult.put(AZURE_ENABLED, "true");
73+
expectedResult.put(LIST.get(0), "false");
74+
for (int i = 1; i < LIST.size(); i++) {
75+
expectedResult.put(LIST.get(i), "true");
76+
}
7077

7178
testConfig(explicitConfig, expectedResult);
7279
}

0 commit comments

Comments
 (0)