Align dynamic config API to kibana send* config options #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasKunz
reviewed
May 22, 2025
| } | ||
|
|
||
| /** Can be executed repeatedly even if sending is currently stopped */ | ||
| public void stopSendingSpans() { |
Contributor
There was a problem hiding this comment.
Is there a particular reason to having start/stop methods instead of just a setSendingSpans(boolean) method?
Contributor
Author
There was a problem hiding this comment.
only my annoyance at the ugly method name. But it makes more sense to align that way, so I've switched to that, thanks!
JonasKunz
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided to provide per signal send_* config options in central config instead of just one global send, so we need those in teh dynamic config API