openai: Remove reduntant unit tests for raw responses and add explicit parsing to existing tests

Author: SrdjanLL

instrumentation/elastic-opentelemetry-instrumentation-openai/tests/cassettes/test_chat_stream_with_raw_response_parsed.yaml

@@ -1171,65 +1171,6 @@ def test_chat_stream_with_raw_response(default_openai_env, trace_exporter, metri
         }
     ]
 
-    chat_completion = client.chat.completions.with_raw_response.create(
-        model=TEST_CHAT_MODEL, messages=messages, stream=True
-    )
-
-    chunks = [chunk.choices[0].delta.content or "" for chunk in chat_completion if chunk.choices]
-    assert "".join(chunks) == "Atlantic Ocean"
-
-    spans = trace_exporter.get_finished_spans()
-    assert len(spans) == 1
-
-    span = spans[0]
-    assert span.name == f"chat {TEST_CHAT_MODEL}"
-    assert span.kind == SpanKind.CLIENT
-    assert span.status.status_code == StatusCode.UNSET
-
-    address, port = address_and_port(client)
-    assert dict(span.attributes) == {
-        GEN_AI_OPENAI_RESPONSE_SERVICE_TIER: "default",
-        GEN_AI_OPERATION_NAME: "chat",
-        GEN_AI_REQUEST_MODEL: TEST_CHAT_MODEL,
-        GEN_AI_SYSTEM: "openai",
-        GEN_AI_RESPONSE_ID: "chatcmpl-BDDnEHqYLBd36X8hHNTQfPKx4KMJT",
-        GEN_AI_RESPONSE_MODEL: TEST_CHAT_RESPONSE_MODEL,
-        GEN_AI_RESPONSE_FINISH_REASONS: ("stop",),
-        SERVER_ADDRESS: address,
-        SERVER_PORT: port,
-    }
-
-    logs = logs_exporter.get_finished_logs()
-    assert len(logs) == 2
-    log_records = logrecords_from_logs(logs)
-    user_message, choice = log_records
-    assert dict(user_message.attributes) == {"gen_ai.system": "openai", "event.name": "gen_ai.user.message"}
-    assert dict(user_message.body) == {}
-
-    assert_stop_log_record(choice)
-
-    (operation_duration_metric,) = get_sorted_metrics(metrics_reader)
-    attributes = {
-        GEN_AI_REQUEST_MODEL: TEST_CHAT_MODEL,
-        GEN_AI_RESPONSE_MODEL: TEST_CHAT_RESPONSE_MODEL,
-    }
-    assert_operation_duration_metric(
-        client, "chat", operation_duration_metric, attributes=attributes, min_data_point=0.006761051714420319
-    )
-
-
-@pytest.mark.skipif(OPENAI_VERSION < (1, 8, 0), reason="LegacyAPIResponse available")
-@pytest.mark.vcr()
-def test_chat_stream_with_raw_response_parsed(default_openai_env, trace_exporter, metrics_reader, logs_exporter):
-    client = openai.OpenAI()
-
-    messages = [
-        {
-            "role": "user",
-            "content": TEST_CHAT_INPUT,
-        }
-    ]
-
     raw_response = client.chat.completions.with_raw_response.create(
         model=TEST_CHAT_MODEL, messages=messages, stream=True
     )
@@ -1238,7 +1179,7 @@ def test_chat_stream_with_raw_response_parsed(default_openai_env, trace_exporter
     chat_completion = raw_response.parse()
 
     chunks = [chunk.choices[0].delta.content or "" for chunk in chat_completion if chunk.choices]
-    assert "".join(chunks) == "South Atlantic Ocean."
+    assert "".join(chunks) == "Atlantic Ocean"
 
     spans = trace_exporter.get_finished_spans()
     assert len(spans) == 1
@@ -1254,7 +1195,7 @@ def test_chat_stream_with_raw_response_parsed(default_openai_env, trace_exporter
         GEN_AI_OPERATION_NAME: "chat",
         GEN_AI_REQUEST_MODEL: TEST_CHAT_MODEL,
         GEN_AI_SYSTEM: "openai",
-        GEN_AI_RESPONSE_ID: "chatcmpl-BRzdBETW1h4E9Vy0Se8CSvrYEXMtC",
+        GEN_AI_RESPONSE_ID: "chatcmpl-BDDnEHqYLBd36X8hHNTQfPKx4KMJT",
         GEN_AI_RESPONSE_MODEL: TEST_CHAT_RESPONSE_MODEL,
         GEN_AI_RESPONSE_FINISH_REASONS: ("stop",),
         SERVER_ADDRESS: address,
@@ -2288,68 +2229,6 @@ async def test_chat_async_stream_with_raw_response(default_openai_env, trace_exp
         }
     ]
 
-    chat_completion = await client.chat.completions.with_raw_response.create(
-        model=TEST_CHAT_MODEL, messages=messages, stream=True
-    )
-
-    chunks = [chunk.choices[0].delta.content or "" async for chunk in chat_completion if chunk.choices]
-    assert "".join(chunks) == "Atlantic Ocean"
-
-    spans = trace_exporter.get_finished_spans()
-    assert len(spans) == 1
-
-    span = spans[0]
-    assert span.name == f"chat {TEST_CHAT_MODEL}"
-    assert span.kind == SpanKind.CLIENT
-    assert span.status.status_code == StatusCode.UNSET
-
-    address, port = address_and_port(client)
-    assert dict(span.attributes) == {
-        GEN_AI_OPENAI_RESPONSE_SERVICE_TIER: "default",
-        GEN_AI_OPERATION_NAME: "chat",
-        GEN_AI_REQUEST_MODEL: TEST_CHAT_MODEL,
-        GEN_AI_SYSTEM: "openai",
-        GEN_AI_RESPONSE_ID: "chatcmpl-BDDnEHqYLBd36X8hHNTQfPKx4KMJT",
-        GEN_AI_RESPONSE_MODEL: TEST_CHAT_RESPONSE_MODEL,
-        GEN_AI_RESPONSE_FINISH_REASONS: ("stop",),
-        SERVER_ADDRESS: address,
-        SERVER_PORT: port,
-    }
-
-    logs = logs_exporter.get_finished_logs()
-    assert len(logs) == 2
-    log_records = logrecords_from_logs(logs)
-    user_message, choice = log_records
-    assert dict(user_message.attributes) == {"gen_ai.system": "openai", "event.name": "gen_ai.user.message"}
-    assert dict(user_message.body) == {}
-
-    assert_stop_log_record(choice)
-
-    (operation_duration_metric,) = get_sorted_metrics(metrics_reader)
-    attributes = {
-        GEN_AI_REQUEST_MODEL: TEST_CHAT_MODEL,
-        GEN_AI_RESPONSE_MODEL: TEST_CHAT_RESPONSE_MODEL,
-    }
-    assert_operation_duration_metric(
-        client, "chat", operation_duration_metric, attributes=attributes, min_data_point=0.006761051714420319
-    )
-
-
-@pytest.mark.skipif(OPENAI_VERSION < (1, 8, 0), reason="LegacyAPIResponse available")
-@pytest.mark.vcr()
-@pytest.mark.asyncio
-async def test_chat_async_stream_with_raw_response_parsed(
-    default_openai_env, trace_exporter, metrics_reader, logs_exporter
-):
-    client = openai.AsyncOpenAI()
-
-    messages = [
-        {
-            "role": "user",
-            "content": TEST_CHAT_INPUT,
-        }
-    ]
-
     raw_response = await client.chat.completions.with_raw_response.create(
         model=TEST_CHAT_MODEL, messages=messages, stream=True
     )
@@ -2358,7 +2237,7 @@ async def test_chat_async_stream_with_raw_response_parsed(
     chat_completion = raw_response.parse()
 
     chunks = [chunk.choices[0].delta.content or "" async for chunk in chat_completion if chunk.choices]
-    assert "".join(chunks) == "South Atlantic Ocean."
+    assert "".join(chunks) == "Atlantic Ocean"
 
     spans = trace_exporter.get_finished_spans()
     assert len(spans) == 1
@@ -2374,7 +2253,7 @@ async def test_chat_async_stream_with_raw_response_parsed(
         GEN_AI_OPERATION_NAME: "chat",
         GEN_AI_REQUEST_MODEL: TEST_CHAT_MODEL,
         GEN_AI_SYSTEM: "openai",
-        GEN_AI_RESPONSE_ID: "chatcmpl-BRzdBETW1h4E9Vy0Se8CSvrYEXMtC",
+        GEN_AI_RESPONSE_ID: "chatcmpl-BDDnEHqYLBd36X8hHNTQfPKx4KMJT",
         GEN_AI_RESPONSE_MODEL: TEST_CHAT_RESPONSE_MODEL,
         GEN_AI_RESPONSE_FINISH_REASONS: ("stop",),
         SERVER_ADDRESS: address,