-
Notifications
You must be signed in to change notification settings - Fork 6
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Based on feedback from #82, follow up and a better long term solution is to add instrumentation support for the LegacyAPIResponse.parse
method, instead of instrument the parse
method on the StreamWrapper
itself.
This will avoid returning the wrapper for the with_raw_response
API calls and aligns more with the flow within the library itself and reduces abstraction leakage on the instrumented StreamWrapper.
Acceptance Criteria:
- Implement
LegacyAPIResponse.parse
instrumentation - Remove
parse
instrumentation added as part of openai: Fix missing parse attribute on StreamWrapper #82 - Ensure the existing tests are passsing.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request