elastic-opentelemetry-instrumentation-openai: register import hook for patching #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r patching Fix a race condition between openai initialization and httpx instrumentation kicking in by loading the openai module when required. This should make the http spans from the api calls of the openai client recorded.
trentm
approved these changes
Oct 16, 2024
| def _uninstrument(self, **kwargs): | ||
| # unwrap only supports uninstrementing real module references so we | ||
| # import here. | ||
| import openai |
Member
There was a problem hiding this comment.
This is unusual (directly importing the thing in an _uninstrument), right?
Member
Author
There was a problem hiding this comment.
Yeah, since openai depends on httpx if we load the openai module earlier and we are loaded before the httpx instrumentation the http spans from the openai client won't be traced
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Fix a race condition between openai initialization and httpx instrumentation kicking in by loading the openai module when required. This should make the http spans from the api calls of the openai client recorded.