openai: adds examples and flattens tests #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an examples directory which include two main features this instrumentation supports: chat and embeddings It also flattens test recordings and infrastructure around unit tests. Notably, instrumentation code doesn't change depending on if azure is used or not. Unit testing only openai (platform) simplifies tests and reduces infrastructure significantly. Signed-off-by: Adrian Cole <[email protected]>
xrmx
reviewed
Jan 9, 2025
instrumentation/elastic-opentelemetry-instrumentation-openai/README.md
Outdated
Show resolved
Hide resolved
instrumentation/elastic-opentelemetry-instrumentation-openai/examples/chat.py
Show resolved
Hide resolved
instrumentation/elastic-opentelemetry-instrumentation-openai/examples/embeddings.py
Show resolved
Hide resolved
instrumentation/elastic-opentelemetry-instrumentation-openai/tests/base.py
Show resolved
Hide resolved
Member
|
Fixed license headers check now need to take a look at integrations tests failure around auth headers |
Member
|
Looks like this is failing because the secrets are not exported to forks |
xrmx
reviewed
Jan 10, 2025
instrumentation/elastic-opentelemetry-instrumentation-openai/tests/test_chat_completions.py
Show resolved
Hide resolved
instrumentation/elastic-opentelemetry-instrumentation-openai/tests/test_chat_completions.py
Show resolved
Hide resolved
instrumentation/elastic-opentelemetry-instrumentation-openai/tests/test_chat_completions.py
Show resolved
Hide resolved
instrumentation/elastic-opentelemetry-instrumentation-openai/tests/test_chat_completions.py
Show resolved
Hide resolved
Member
|
Fixed CI and updated integrations tests that started to return the service tier in the response |
xrmx
reviewed
Jan 10, 2025
instrumentation/elastic-opentelemetry-instrumentation-openai/README.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Adrian Cole <[email protected]>
xrmx
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
This adds an examples directory which include two main features this instrumentation supports: chat and embeddings
It also flattens test recordings and infrastructure around unit tests. Notably, instrumentation code doesn't change depending on if azure is used or not. Unit testing only openai (platform) simplifies tests and reduces infrastructure significantly.