openai: decouple metrics from span recording #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When spans are not recording the attributes are not accessible and so we'll crash trying to access them in metrics. Instead decouple the metrics code from the span and instead pass just the attributes.
anuraaga
approved these changes
Feb 27, 2025
...ic-opentelemetry-instrumentation-openai/src/opentelemetry/instrumentation/openai/__init__.py
Outdated
Show resolved
Hide resolved
estolfo
approved these changes
Feb 27, 2025
This was referenced Feb 27, 2025
Contributor
|
good work, this is the ideal solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
When spans are not recording the attributes are not accessible and so we'll crash trying to access them in metrics code. So decouple the metrics code from the span and instead use the plain attributes.
Related issues
Closes #53