openai: fix instrumentation of with_raw_response #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we have whatever attribute the callers expect.
xrmx
force-pushed
the
stream-wrapper-rewrite
branch
from
898cbf2 to
1e24fd4
Compare
xrmx
changed the title
xrmx
commented
Mar 21, 2025
...ic-opentelemetry-instrumentation-openai/src/opentelemetry/instrumentation/openai/__init__.py
Outdated
Show resolved
Hide resolved
And move the check for a raw response to an helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
This change StreamWrapper to intherit from ObjectProxy so we have whatever attribute the callers expect. Then we need to handle the case when the response of the api call is a LegacyAPIResponse that needs to parsed.
Related issues
Refs #61