Skip to content

Commit 6fdb504

Browse files
committed
distro: enable containerid resource detector
1 parent 2e09f44 commit 6fdb504

File tree

3 files changed

+17
-2
lines changed

3 files changed

+17
-2
lines changed

src/elasticotel/distro/__init__.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,13 @@ def _configure(self, **kwargs):
119119
os.environ.setdefault(OTEL_TRACES_SAMPLER, "parentbased_traceidratio")
120120
os.environ.setdefault(OTEL_TRACES_SAMPLER_ARG, "1.0")
121121

122-
base_resource_detectors = ["process_runtime", "os", "otel", "telemetry_distro", "service_instance"]
122+
base_resource_detectors = [
123+
"process_runtime",
124+
"os",
125+
"otel",
126+
"telemetry_distro",
127+
"service_instance",
128+
"containerid",
129+
]
123130
detectors = base_resource_detectors + get_cloud_resource_detectors()
124131
os.environ.setdefault(OTEL_EXPERIMENTAL_RESOURCE_DETECTORS, ",".join(detectors))

tests/distro/test_distro.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ def test_default_configuration(self):
4949
self.assertEqual("otlp", os.environ.get(OTEL_LOGS_EXPORTER))
5050
self.assertEqual("grpc", os.environ.get(OTEL_EXPORTER_OTLP_PROTOCOL))
5151
self.assertEqual(
52-
"process_runtime,os,otel,telemetry_distro,service_instance,_gcp,aws_ec2,aws_ecs,aws_elastic_beanstalk,azure_app_service,azure_vm",
52+
"process_runtime,os,otel,telemetry_distro,service_instance,containerid,_gcp,aws_ec2,aws_ecs,aws_elastic_beanstalk,azure_app_service,azure_vm",
5353
os.environ.get(OTEL_EXPERIMENTAL_RESOURCE_DETECTORS),
5454
)
5555
self.assertEqual("always_off", os.environ.get(OTEL_METRICS_EXEMPLAR_FILTER))

tests/integration/test_integration.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,10 @@
1818

1919
import pytest
2020

21+
from opentelemetry.resource.detector.containerid import (
22+
ContainerResourceDetector,
23+
)
24+
2125
from .utils import ElasticIntegrationTestCase, OTEL_INSTRUMENTATION_VERSION, ROOT_DIR
2226

2327

@@ -49,6 +53,10 @@ def test_traces_default_resource_attributes(self):
4953
self.assertTrue(resource["os.type"])
5054
self.assertTrue(resource["os.version"])
5155

56+
container_id = ContainerResourceDetector().detect().attributes.get("container.id")
57+
if container_id:
58+
self.assertEqual(resource["container.id"], container_id)
59+
5260
def test_traces_sets_resource_attributes_from_env(self):
5361
env = {"OTEL_RESOURCE_ATTRIBUTES": "service.name=my-service"}
5462
stdout, stderr, returncode = self.run_script(

0 commit comments

Comments
 (0)