Skip to content

Commit 726ea63

Browse files
committed
distro: disable exemplars by default
Since they are not very mature
1 parent ba6926a commit 726ea63

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ This distribution sets the following defaults:
7979
- `OTEL_METRICS_EXPORTER`: `otlp`
8080
- `OTEL_EXPORTER_OTLP_PROTOCOL`: `grpc`
8181
- `OTEL_EXPERIMENTAL_RESOURCE_DETECTORS`: `process_runtime,os,otel,telemetry_distro`
82+
- `OTEL_METRICS_EXEMPLAR_FILTER`: `always_off`
8283

8384
### Distribution specific configuration variables
8485

src/elasticotel/distro/__init__.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
)
3131
from opentelemetry.sdk._configuration import _OTelSDKConfigurator
3232
from opentelemetry.sdk.environment_variables import (
33+
OTEL_METRICS_EXEMPLAR_FILTER,
3334
OTEL_EXPERIMENTAL_RESOURCE_DETECTORS,
3435
OTEL_EXPORTER_OTLP_PROTOCOL,
3536
)
@@ -68,3 +69,5 @@ def _configure(self, **kwargs):
6869
os.environ.setdefault(OTEL_LOGS_EXPORTER, "otlp")
6970
os.environ.setdefault(OTEL_EXPORTER_OTLP_PROTOCOL, "grpc")
7071
os.environ.setdefault(OTEL_EXPERIMENTAL_RESOURCE_DETECTORS, "process_runtime,os,otel,telemetry_distro")
72+
# disable exemplars by default for now
73+
os.environ.setdefault(OTEL_METRICS_EXEMPLAR_FILTER, "always_off")

tests/distro/test_distro.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
OTEL_TRACES_EXPORTER,
2626
)
2727
from opentelemetry.sdk.environment_variables import (
28+
OTEL_METRICS_EXEMPLAR_FILTER,
2829
OTEL_EXPERIMENTAL_RESOURCE_DETECTORS,
2930
OTEL_EXPORTER_OTLP_PROTOCOL,
3031
)
@@ -42,6 +43,7 @@ def test_default_configuration(self):
4243
self.assertEqual(
4344
"process_runtime,os,otel,telemetry_distro", os.environ.get(OTEL_EXPERIMENTAL_RESOURCE_DETECTORS)
4445
)
46+
self.assertEqual("always_off", os.environ.get(OTEL_METRICS_EXEMPLAR_FILTER))
4547

4648
@mock.patch.dict("os.environ", {}, clear=True)
4749
def test_load_instrumentor_call_with_default_kwargs_for_SystemMetricsInstrumentor(self):

0 commit comments

Comments
 (0)