Skip to content

Commit 97a7e93

Browse files
authored
distro: set OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE to DELTA (#197)
We have issues accepting Histograms that does not have DELTA temporality.
1 parent 0f5d604 commit 97a7e93

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

src/elasticotel/distro/__init__.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@
4848
from opentelemetry.sdk.environment_variables import (
4949
OTEL_METRICS_EXEMPLAR_FILTER,
5050
OTEL_EXPERIMENTAL_RESOURCE_DETECTORS,
51+
OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE,
5152
OTEL_EXPORTER_OTLP_PROTOCOL,
5253
_OTEL_PYTHON_LOGGING_AUTO_INSTRUMENTATION_ENABLED,
5354
)
@@ -141,3 +142,5 @@ def _configure(self, **kwargs):
141142
os.environ.setdefault(OTEL_EXPERIMENTAL_RESOURCE_DETECTORS, "process_runtime,os,otel,telemetry_distro")
142143
# disable exemplars by default for now
143144
os.environ.setdefault(OTEL_METRICS_EXEMPLAR_FILTER, "always_off")
145+
# preference to use DELTA temporality as we can handle only this kind of Histograms
146+
os.environ.setdefault(OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE, "DELTA")

tests/distro/test_distro.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
from opentelemetry.sdk.environment_variables import (
2828
OTEL_METRICS_EXEMPLAR_FILTER,
2929
OTEL_EXPERIMENTAL_RESOURCE_DETECTORS,
30+
OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE,
3031
OTEL_EXPORTER_OTLP_PROTOCOL,
3132
)
3233

@@ -44,6 +45,7 @@ def test_default_configuration(self):
4445
"process_runtime,os,otel,telemetry_distro", os.environ.get(OTEL_EXPERIMENTAL_RESOURCE_DETECTORS)
4546
)
4647
self.assertEqual("always_off", os.environ.get(OTEL_METRICS_EXEMPLAR_FILTER))
48+
self.assertEqual("DELTA", os.environ.get(OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE))
4749

4850
@mock.patch.dict("os.environ", {}, clear=True)
4951
def test_load_instrumentor_call_with_default_kwargs_for_SystemMetricsInstrumentor(self):

0 commit comments

Comments
 (0)