Skip to content

Commit b9b8ef8

Browse files
authored
Rever requirement of using nested type for arrays of objects (#1495)
1 parent 7edab9f commit b9b8ef8

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

internal/fields/validate.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,6 @@ var (
3535
semver3_0_0 = semver.MustParse("3.0.0")
3636

3737
defaultExternal = "ecs"
38-
39-
errArrayOfObjects = errors.New("array of objects not used as nested type can lead to unexpected results")
4038
)
4139

4240
// Validator is responsible for fields validation.
@@ -795,9 +793,6 @@ func (v *Validator) parseSingleElementValue(key string, definition FieldDefiniti
795793
break
796794
}
797795
errs := v.validateMapElement(key, common.MapStr(val), doc)
798-
if definition.Type == "group" {
799-
errs = append(errs, errArrayOfObjects)
800-
}
801796
if len(errs) == 0 {
802797
return nil
803798
}

internal/fields/validate_test.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -646,9 +646,8 @@ func Test_parseElementValue(t *testing.T) {
646646
fail: true,
647647
assertError: func(t *testing.T, err error) {
648648
errs := err.(multierror.Error)
649-
if assert.Len(t, errs, 2) {
649+
if assert.Len(t, errs, 1) {
650650
assert.Contains(t, errs[0].Error(), `"details.hostname" is undefined`)
651-
assert.ErrorIs(t, errs[1], errArrayOfObjects)
652651
}
653652
},
654653
},

0 commit comments

Comments
 (0)