Update default value for env. var used for Wolfi images (#2083)

Update default value for environment variable used to enable
or disable the usage of Elastic Agent images based on Wolfi. From
now on, wolfi images will be used by default starting with Elastic
stack versions 8.16.0.

Author: mrodm

internal/install/application_configuration.go

@@ -162,10 +162,10 @@ func selectElasticAgentImageName(version, agentBaseImage string) string {
 		return elasticAgentLegacyImageName
 	}
 
-	disableWolfiImages := true
+	disableWolfiImages := false
 	valueEnv, ok := os.LookupEnv(disableElasticAgentWolfiEnvVar)
-	if ok && strings.ToLower(valueEnv) != "true" {
-		disableWolfiImages = false
+	if ok && strings.ToLower(valueEnv) != "false" {
+		disableWolfiImages = true
 	}
 	switch {
 	case agentBaseImage == "complete":

internal/install/application_configuration_test.go

@@ -53,14 +53,14 @@ func TestSelectElasticAgentImageName_NextStackInOwnNamespace(t *testing.T) {
 	assert.Equal(t, selected, elasticAgentCompleteImageName)
 }
 
-func TestSelectElasticAgentImageName_DefaultImage816_WihtoutEnvVar(t *testing.T) {
+func TestSelectElasticAgentImageName_DefaultImage816_WithoutEnvVar(t *testing.T) {
 	version := stackVersion8160
 	// Try to keep the test agnostic from the environment variables defined in CI
 	t.Setenv(disableElasticAgentWolfiEnvVar, "")
 	os.Unsetenv(disableElasticAgentWolfiEnvVar)
 
 	selected := selectElasticAgentImageName(version, "")
-	assert.Equal(t, selected, elasticAgentCompleteImageName)
+	assert.Equal(t, selected, elasticAgentWolfiImageName)
 }
 
 func TestSelectElasticAgentImageName_DisableWolfiImageEnvVar(t *testing.T) {