Skip to content

Commit 6da5464

Browse files
committed
Link to HTTPX issue in badssl tests
1 parent 573cae1 commit 6da5464

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

tests/node/test_tls_versions.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,8 @@ async def test_unsupported_tls_versions(
130130
node_config = url_to_node_config(url).replace(ssl_version=ssl_version)
131131
node = node_class(node_config)
132132

133+
# Remove ConnectionError when we have a fix or workaround for
134+
# https://github.com/encode/httpx/discussions/3674
133135
with pytest.raises((TlsError, ConnectionError)) as e:
134136
await await_if_coro(node.perform_request("GET", "/"))
135137
if anyio_backend == "trio" and node_class is HttpxAsyncHttpNode:
@@ -140,6 +142,8 @@ async def test_unsupported_tls_versions(
140142
@node_classes
141143
@pytest.mark.parametrize("ssl_version", [0, "TLSv1", object()])
142144
def test_ssl_version_value_error(node_class, ssl_version):
145+
# Remove ConnectionError when we have a fix or workaround for
146+
# https://github.com/encode/httpx/discussions/3674
143147
with pytest.raises((ValueError, ConnectionError)) as e:
144148
node_class(NodeConfig("https", "localhost", 9200, ssl_version=ssl_version))
145149
assert str(e.value) == (

0 commit comments

Comments
 (0)