Populate document.save/update result value

Author: amih90

elasticsearch_dsl/document.py

@@ -345,6 +345,8 @@ def update(self, using=None, index=None,  detect_noop=True,
         :arg doc_as_upsert:  Instead of sending a partial doc plus an upsert
             doc, setting doc_as_upsert to true will use the contents of doc as
             the upsert value
+
+        :return operation result noop/updated
         """
         body = {
             'doc_as_upsert': doc_as_upsert,
@@ -406,6 +408,8 @@ def update(self, using=None, index=None,  detect_noop=True,
             if '_' + k in meta:
                 setattr(self.meta, k, meta['_' + k])
 
+        return meta['result']
+
     def save(self, using=None, index=None, validate=True, skip_empty=True, **kwargs):
         """
         Save the document into elasticsearch. If the document doesn't exist it
@@ -422,6 +426,8 @@ def save(self, using=None, index=None, validate=True, skip_empty=True, **kwargs)
 
         Any additional keyword arguments will be passed to
         ``Elasticsearch.index`` unchanged.
+
+        :return operation result created/updated
         """
         if validate:
             self.full_clean()
@@ -445,8 +451,8 @@ def save(self, using=None, index=None, validate=True, skip_empty=True, **kwargs)
             if '_' + k in meta:
                 setattr(self.meta, k, meta['_' + k])
 
-        # return True/False if the document has been created/updated
-        return meta['result'] == 'created'
+        return meta['result']
 
 # limited backwards compatibility, to be removed in 7.0.0
 DocType = Document
+

test_elasticsearch_dsl/test_integration/test_document.py

@@ -152,7 +152,7 @@ def test_update_object_field(write_client):
     w = Wiki(owner=User(name='Honza Kral'), _id='elasticsearch-py')
     w.save()
 
-    w.update(owner=[{'name': 'Honza'}, {'name': 'Nick'}])
+    assert 'updated' == w.update(owner=[{'name': 'Honza'}, {'name': 'Nick'}])
     assert w.owner[0].name == 'Honza'
     assert w.owner[1].name == 'Nick'
 
@@ -270,7 +270,7 @@ def test_save_updates_existing_doc(data_client):
 
     elasticsearch_repo.new_field = 'testing-save'
     v = elasticsearch_repo.meta.version
-    assert not elasticsearch_repo.save()
+    assert 'updated' == elasticsearch_repo.save()
 
     # assert version has been updated
     assert elasticsearch_repo.meta.version == v + 1