Checkstyle, rename 'client' to 'esClient'

Author: swallez

java-client/src/test/java/co/elastic/clients/documentation/api_conventions/ApiConventionsTest.java

@@ -35,8 +35,6 @@
 import co.elastic.clients.util.ApiTypeHelper;
 import com.fasterxml.jackson.annotation.JsonCreator;
 import com.fasterxml.jackson.annotation.JsonProperty;
-import com.fasterxml.jackson.databind.ObjectMapper;
-import com.fasterxml.jackson.databind.PropertyNamingStrategies;
 import jakarta.json.JsonArray;
 import jakarta.json.JsonObject;
 import jakarta.json.JsonValue;
@@ -62,9 +60,9 @@ public void blockingAndAsync() throws Exception {
 
         //tag::blocking-and-async
         // Synchronous blocking client
-        ElasticsearchClient client = new ElasticsearchClient(transport);
+        ElasticsearchClient esClient = new ElasticsearchClient(transport);
 
-        if (client.exists(b -> b.index("products").id("foo")).value()) {
+        if (esClient.exists(b -> b.index("products").id("foo")).value()) {
             logger.info("product exists");
         }
 
@@ -92,8 +90,8 @@ private ElasticsearchClient createClient() {
     public void builders() throws Exception {
 
         //tag::builders
-        ElasticsearchClient client = createClient();
-        CreateIndexResponse createResponse = client.indices().create(
+        ElasticsearchClient esClient = createClient();
+        CreateIndexResponse createResponse = esClient.indices().create(
             new CreateIndexRequest.Builder()
                 .index("my-index")
                 .aliases("foo",
@@ -107,8 +105,8 @@ public void builders() throws Exception {
     public void builderLambdas() throws Exception {
 
         //tag::builder-lambdas
-        ElasticsearchClient client = createClient();
-        CreateIndexResponse createResponse = client.indices()
+        ElasticsearchClient esClient = createClient();
+        CreateIndexResponse createResponse = esClient.indices()
             .create(createIndexBuilder -> createIndexBuilder
                 .index("my-index")
                 .aliases("foo", aliasBuilder -> aliasBuilder
@@ -121,8 +119,8 @@ public void builderLambdas() throws Exception {
     public void builderLambdasShort() throws Exception {
 
         //tag::builder-lambdas-short
-        ElasticsearchClient client = createClient();
-        CreateIndexResponse createResponse = client.indices()
+        ElasticsearchClient esClient = createClient();
+        CreateIndexResponse createResponse = esClient.indices()
             .create(c -> c
                 .index("my-index")
                 .aliases("foo", a -> a
@@ -134,8 +132,8 @@ public void builderLambdasShort() throws Exception {
 
     public void builderIntervals() throws Exception {
         //tag::builder-intervals
-        ElasticsearchClient client = createClient();
-        SearchResponse<SomeApplicationData> results = client
+        ElasticsearchClient esClient = createClient();
+        SearchResponse<SomeApplicationData> results = esClient
             .search(b0 -> b0
                 .query(b1 -> b1
                     .intervals(b2 -> b2

java-client/src/test/java/co/elastic/clients/documentation/api_conventions/LoadingJsonTest.java

@@ -47,7 +47,7 @@
 public class LoadingJsonTest extends ModelTestCase {
 
     private final DocTestsTransport transport = new DocTestsTransport();
-    private final ElasticsearchClient client = new ElasticsearchClient(transport);
+    private final ElasticsearchClient esClient = new ElasticsearchClient(transport);
 
     private static final SearchResponse<JsonData> searchResponse = SearchResponse.of(b -> b
         .aggregations(new HashMap<>())
@@ -82,7 +82,7 @@ public void loadIndexDefinition() throws IOException {
             .withJson(input) // <2>
         );
 
-        boolean created = client.indices().create(req).acknowledged();
+        boolean created = esClient.indices().create(req).acknowledged();
         //end::load-index
     }
 
@@ -102,7 +102,7 @@ public void ingestDocument() throws IOException {
             .withJson(file)
         );
 
-        client.index(req);
+        esClient.index(req);
         //end::ingest-data
     }
 
@@ -136,7 +136,7 @@ public void query1() throws IOException {
             .size(0)
         );
 
-        Map<String, Aggregate> aggs = client
+        Map<String, Aggregate> aggs = esClient
             .search(aggRequest, Void.class) // <3>
             .aggregations();
         //end::query
@@ -185,7 +185,7 @@ public void query2() throws IOException {
             .ignoreUnavailable(true) // <5>
         );
 
-        Map<String, Aggregate> aggs = client
+        Map<String, Aggregate> aggs = esClient
             .search(aggRequest, Void.class)
             .aggregations();
         //end::query-and-agg