Skip to content

Commit f09e23c

Browse files
committed
Remove Node.boundHosts: it's mostly useless in the container era
1 parent de27a94 commit f09e23c

File tree

1 file changed

+4
-14
lines changed
  • java-client/src/main/java/co/elastic/clients/transport/http

1 file changed

+4
-14
lines changed

java-client/src/main/java/co/elastic/clients/transport/http/Node.java

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121

2222
import javax.annotation.Nullable;
2323
import java.net.URI;
24-
import java.util.List;
2524
import java.util.Map;
2625
import java.util.Objects;
2726
import java.util.Set;
@@ -35,7 +34,6 @@ public class Node {
3534
private final String version;
3635
private final Set<String> roles;
3736
private final Map<String, String> attributes;
38-
private final List<String> boundHosts;
3937

4038
/**
4139
* Create a node with its URI, roles and attributes.
@@ -45,17 +43,15 @@ public class Node {
4543
* @param uri the node's URI
4644
* @param name the node name/identifier
4745
* @param version the node's version, if known
48-
* @param roles the node's roles (such as "master", "ingest", etc).
46+
* @param roles the node's roles, such as "master", "ingest", etc.
4947
* @param attributes the node's attributes. This can be used for routing decisions by multi-node implementations.
50-
* @param boundHosts addresses on which the node is listening. Useful to find a host based on any address it's listening to.
5148
*/
5249
public Node(
5350
URI uri,
5451
@Nullable String name,
5552
@Nullable String version,
5653
@Nullable Set<String> roles,
57-
@Nullable Map<String, String> attributes,
58-
@Nullable List<String> boundHosts
54+
@Nullable Map<String, String> attributes
5955
) {
6056

6157
if (!uri.isAbsolute()) {
@@ -71,15 +67,14 @@ public Node(
7167
this.version = version;
7268
this.roles = roles;
7369
this.attributes = attributes;
74-
this.boundHosts = boundHosts;
7570
}
7671

7772
public Node(URI uri) {
78-
this(uri, null, null, null, null, null);
73+
this(uri, null, null, null, null);
7974
}
8075

8176
public Node(String uri) {
82-
this(URI.create(uri), null, null, null, null, null);
77+
this(URI.create(uri), null, null, null, null);
8378
}
8479

8580
/**
@@ -112,11 +107,6 @@ public Map<String, String> attributes() {
112107
return attributes;
113108
}
114109

115-
@Nullable
116-
public List<String> boundHosts() {
117-
return boundHosts;
118-
}
119-
120110
@Override
121111
public String toString() {
122112
return uri.toString();

0 commit comments

Comments
 (0)