Deep merge options on client instantiation (#2890) (#2898)

Author: JoshMock

src/client.ts

@@ -260,6 +260,12 @@ export default class Client extends API {
       }
     }
 
+    const headers: Record<string, any> = Object.assign({}, {
+      'user-agent': `elasticsearch-js/${clientVersion} (${os.platform()} ${os.release()}-${os.arch()}; Node.js ${nodeVersion}; Transport ${transportVersion})`
+    }, opts.headers ?? {})
+
+    const redaction = Object.assign({}, { type: 'replace', additionalKeys: [] }, opts.redaction ?? {})
+
     const options: Required<ClientOptions> = Object.assign({}, {
       Connection: UndiciConnection,
       Transport: SniffingTransport,
@@ -277,9 +283,6 @@ export default class Client extends API {
       tls: null,
       caFingerprint: null,
       agent: null,
-      headers: {
-        'user-agent': `elasticsearch-js/${clientVersion} (${os.platform()} ${os.release()}-${os.arch()}; Node.js ${nodeVersion}; Transport ${transportVersion})`
-      },
       nodeFilter: null,
       generateRequestId: null,
       name: 'elasticsearch-js',
@@ -289,12 +292,8 @@ export default class Client extends API {
       proxy: null,
       enableMetaHeader: true,
       maxResponseSize: null,
-      maxCompressedResponseSize: null,
-      redaction: {
-        type: 'replace',
-        additionalKeys: []
-      }
-    }, opts)
+      maxCompressedResponseSize: null
+    }, opts, { headers, redaction })
 
     if (options.caFingerprint != null && isHttpConnection(opts.node ?? opts.nodes)) {
       throw new errors.ConfigurationError('You can\'t configure the caFingerprint with a http connection')

test/unit/client.test.ts

@@ -111,6 +111,28 @@ test('Custom headers', t => {
   t.end()
 })
 
+test('Custom headers should merge, not overwrite', t => {
+  const client = new Client({
+    node: 'http://localhost:9200',
+    headers: { foo: 'bar' }
+  })
+  t.ok(client.transport[symbols.kHeaders]['user-agent']?.startsWith('elasticsearch-js/'))
+  t.end()
+})
+
+test('Redaction options should merge, not overwrite', t => {
+  const client = new Client({
+    node: 'http://localhost:9200',
+    // @ts-expect-error
+    redaction: {
+      additionalKeys: ['foo'],
+    }
+  })
+  t.equal(client.transport[symbols.kRedaction].type, 'replace')
+  t.match(client.transport[symbols.kRedaction].additionalKeys, ['foo'])
+  t.end()
+})
+
 test('Basic auth', async t => {
   t.plan(1)