manual backport of fixes made in master for #2115, better xmldocs for generated Indices/Types related methods

Author: Mpdreamz

src/CodeGeneration/ApiGenerator/Domain/ApiUrlPart.cs

@@ -6,10 +6,19 @@ public class ApiUrlPart
 	{
 		public string Name { get; set; }
 		public string Type { get; set; }
-		public string Description { get; set; }
+
+		private string _description;
+		public string Description { get { return _description; } set { _description = CleanUpDescription(value); } }
+
 		public bool Required { get; set; }
 		public IEnumerable<string> Options { get; set; }
 
+		private string CleanUpDescription(string value)
+		{
+			if (string.IsNullOrWhiteSpace(value)) return value;
+			return value.Replace("use `_all` or empty string", "use the special string `_all` or Indices.All");
+		}
+
 		public string ClrTypeName
 		{
 			get

src/CodeGeneration/ApiGenerator/Domain/CsharpMethod.cs

@@ -252,19 +252,19 @@ public IEnumerable<FluentRouteSetter> GetFluentRouteSetters()
 				{
 					code = $"public {returnType} {p.InterfaceName}<TOther>() where TOther : class ";
 					code += $"=> Assign(a=>a.RouteValues.{routeSetter}(\"{p.Name}\", ({p.ClrTypeName})typeof(TOther)));";
-					xmlDoc = $"///<summary>{p.Description}</summary>";
+					xmlDoc = $"///<summary>a shortcut into calling {p.InterfaceName}(typeof(TOther))</summary>";
 					setters.Add(new FluentRouteSetter { Code = code, XmlDoc = xmlDoc });
 				}
 				if (paramName == "index" && p.Type == "list")
 				{
 					code = $"public {returnType} AllIndices() => this.Index(Indices.All);";
-					xmlDoc = $"///<summary>{p.Description}</summary>";
+					xmlDoc = $"///<summary>A shortcut into calling Index(Indices.All)</summary>";
 					setters.Add(new FluentRouteSetter { Code = code, XmlDoc = xmlDoc });
 				}
 				if (paramName == "type" && p.Type == "list")
 				{
 					code = $"public {returnType} AllTypes() => this.Type(Types.All);";
-					xmlDoc = $"///<summary>{p.Description}</summary>";
+					xmlDoc = $"///<summary>a shortcut into calling Type(Types.All)</summary>";
 					setters.Add(new FluentRouteSetter { Code = code, XmlDoc = xmlDoc });
 				}
 				if (paramName == "fields" && p.Type == "list")