Implement IParsable<T> for url parameters

Author: flobernd

global.json

@@ -1,10 +1,7 @@
 {
   "sdk": {
-    "version": "8.0.400",
+    "version": "9.0.100",
     "rollForward": "latestFeature",
     "allowPrerelease": false
-  },
-  "version": "8.8.0-alpha.1",
-  "doc_current": "main",
-  "doc_branch": "main"
+  }
 }

src/Elastic.Clients.Elasticsearch/_Shared/Core/DateTime/Duration.cs

@@ -3,6 +3,8 @@
 // See the LICENSE file in the project root for more information.
 
 using System;
+using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.Globalization;
 using System.Text.Json;
 using System.Text.Json.Serialization;
@@ -15,7 +17,13 @@ namespace Elastic.Clients.Elasticsearch;
 /// Represents a duration value.
 /// </summary>
 [JsonConverter(typeof(DurationConverter))]
-public sealed class Duration : IComparable<Duration>, IEquatable<Duration>, IUrlParameter
+public sealed class Duration :
+	IComparable<Duration>,
+	IEquatable<Duration>,
+	IUrlParameter
+#if NET7_0_OR_GREATER
+	, IParsable<Duration>
+#endif
 {
 	private const double MicrosecondsInATick = 0.1; // 10 ticks = 1 microsecond
 	private const double MillisecondsInADay = MillisecondsInAnHour * 24;
@@ -390,6 +398,35 @@ private static string ExponentFormat(double d)
 		var exponent = (int)((bits >> 52) & 0x7ffL);
 		return new string('#', Math.Max(2, exponent));
 	}
+
+	#region IParsable
+
+	public static Duration Parse(string s, IFormatProvider? provider) =>
+		TryParse(s, provider, out var result) ? result : throw new FormatException();
+
+	public static bool TryParse([NotNullWhen(true)] string? s, IFormatProvider? provider,
+		[NotNullWhen(true)] out Duration? result)
+	{
+		if (s is null)
+		{
+			result = null;
+			return false;
+		}
+
+		try
+		{
+			result = new Duration(s);
+		}
+		catch
+		{
+			result = null;
+			return false;
+		}
+
+		return true;
+	}
+
+	#endregion IParsable
 }
 
 internal sealed class DurationConverter : JsonConverter<Duration>

src/Elastic.Clients.Elasticsearch/_Shared/Core/Fluent/Descriptor.cs

@@ -58,7 +58,11 @@ public abstract class Descriptor<TDescriptor> : Descriptor
 	protected TDescriptor Self => _self;
 
 	[MethodImpl(MethodImplOptions.AggressiveInlining)]
-	protected TDescriptor Assign<TValue>(TValue value, Action<TDescriptor, TValue> assign) => FluentAssign.Assign(_self, value, assign);
+	protected TDescriptor Assign<TValue>(TValue value, Action<TDescriptor, TValue> assign)
+	{
+		assign(_self, value);
+		return _self;
+	}
 }
 
 public abstract class SerializableDescriptor<TDescriptor> : Descriptor<TDescriptor>, ISelfSerializable

src/Elastic.Clients.Elasticsearch/_Shared/Core/Fluent/Fluent.cs

@@ -24,6 +24,9 @@ namespace Elastic.Clients.Elasticsearch;
 public sealed class Field :
 	IEquatable<Field>,
 	IUrlParameter
+#if NET7_0_OR_GREATER
+	, IParsable<Field>
+#endif
 {
 	private readonly object _comparisonValue;
 	private readonly Type? _type;
@@ -197,6 +200,26 @@ public override int GetHashCode()
 
 	#endregion Equality
 
+	#region IParsable
+
+	public static Field Parse(string s, IFormatProvider? provider) =>
+		TryParse(s, provider, out var result) ? result : throw new FormatException();
+
+	public static bool TryParse([NotNullWhen(true)] string? s, IFormatProvider? provider,
+		[NotNullWhen(true)] out Field? result)
+	{
+		if (s is null)
+		{
+			result = null;
+			return false;
+		}
+
+		result = new Field(s);
+		return true;
+	}
+
+	#endregion IParsable
+
 	#region IUrlParameter
 
 	string IUrlParameter.GetString(ITransportConfiguration settings)

src/Elastic.Clients.Elasticsearch/_Shared/Core/Infer/Field/Field.cs

@@ -6,6 +6,7 @@
 using System.Collections;
 using System.Collections.Generic;
 using System.Diagnostics;
+using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 using System.Linq.Expressions;
 using System.Reflection;
@@ -19,6 +20,9 @@ public sealed class Fields :
 	IEquatable<Fields>,
 	IEnumerable<Field>,
 	IUrlParameter
+#if NET7_0_OR_GREATER
+	, IParsable<Fields>
+#endif
 {
 	internal readonly List<Field> ListOfFields;
 
@@ -183,6 +187,44 @@ public override bool Equals(object? obj) =>
 
 	#endregion IEnumerable
 
+	#region IParsable
+
+	public static Fields Parse(string s, IFormatProvider? provider) =>
+		TryParse(s, provider, out var result) ? result : throw new FormatException();
+
+	public static bool TryParse([NotNullWhen(true)] string? s, IFormatProvider? provider,
+		[NotNullWhen(true)] out Fields? result)
+	{
+		if (s is null)
+		{
+			result = null;
+			return false;
+		}
+
+		if (s.IsNullOrEmptyCommaSeparatedList(out var list))
+		{
+			result = new Fields();
+			return true;
+		}
+
+		var fields = new List<Field>();
+		foreach (var item in list)
+		{
+			if (!Field.TryParse(item, provider, out var field))
+			{
+				result = null;
+				return false;
+			}
+
+			fields.Add(field);
+		}
+
+		result = new Fields(fields);
+		return true;
+	}
+
+	#endregion IParsable
+
 	#region IUrlParameter
 
 	string IUrlParameter.GetString(ITransportConfiguration? settings)

src/Elastic.Clients.Elasticsearch/_Shared/Core/Infer/Fields/Fields.cs

@@ -4,16 +4,23 @@
 
 using System;
 using System.Diagnostics;
+using System.Diagnostics.CodeAnalysis;
 using System.Globalization;
 using System.Text.Json;
 using System.Text.Json.Serialization;
+
 using Elastic.Transport;
 
 namespace Elastic.Clients.Elasticsearch;
 
 [DebuggerDisplay("{DebugDisplay,nq}")]
 [JsonConverter(typeof(IdConverter))]
-public class Id : IEquatable<Id>, IUrlParameter
+public class Id :
+	IEquatable<Id>,
+	IUrlParameter
+#if NET7_0_OR_GREATER
+	, IParsable<Id>
+#endif
 {
 	public Id(string id)
 	{
@@ -81,12 +88,16 @@ public override bool Equals(object obj)
 		{
 			case Id r:
 				return Equals(r);
+
 			case string s:
 				return Equals(s);
+
 			case int l:
 				return Equals(l);
+
 			case long l:
 				return Equals(l);
+
 			case Guid g:
 				return Equals(g);
 		}
@@ -108,4 +119,24 @@ public override int GetHashCode()
 	public static bool operator ==(Id left, Id right) => Equals(left, right);
 
 	public static bool operator !=(Id left, Id right) => !Equals(left, right);
+
+	#region IParsable
+
+	public static Id Parse(string s, IFormatProvider? provider) =>
+		TryParse(s, provider, out var result) ? result : throw new FormatException();
+
+	public static bool TryParse([NotNullWhen(true)] string? s, IFormatProvider? provider,
+		[NotNullWhen(true)] out Id? result)
+	{
+		if (s is null)
+		{
+			result = null;
+			return false;
+		}
+
+		result = new Id(s);
+		return true;
+	}
+
+	#endregion IParsable
 }

src/Elastic.Clients.Elasticsearch/_Shared/Core/Infer/Id/Id.cs

@@ -5,30 +5,42 @@
 using System;
 using System.Collections.Generic;
 using System.Diagnostics;
+using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 using System.Text.Json.Serialization;
+
 using Elastic.Transport;
 
 namespace Elastic.Clients.Elasticsearch;
 
 [DebuggerDisplay("{DebugDisplay,nq}")]
 [JsonConverter(typeof(IdsConverter))]
-public partial class Ids : IUrlParameter, IEquatable<Ids>
+public class Ids :
+	IUrlParameter,
+	IEquatable<Ids>
+#if NET7_0_OR_GREATER
+	, IParsable<Ids>
+#endif
 {
 	private readonly IList<Id> _ids;
 
 	public Ids(IEnumerable<Id> ids) => _ids = ids.ToList();
 
 	public Ids(IList<Id> ids) => _ids = ids;
 
-	public Ids(IEnumerable<string> ids) => _ids = ids.Select(i  => new Id(i)).ToList();
+	public Ids(IEnumerable<string> ids) => _ids = ids.Select(i => new Id(i)).ToList();
 
 	public Ids(string value)
 	{
 		if (!value.IsNullOrEmptyCommaSeparatedList(out var arr))
 			_ids = arr.Select(i => new Id(i)).ToList();
 	}
 
+	public Ids()
+	{
+		_ids = [];
+	}
+
 	internal IList<Id> IdsToSerialize => _ids;
 
 	private string DebugDisplay => ((IUrlParameter)this).GetString(null);
@@ -82,4 +94,42 @@ public override int GetHashCode()
 	public static bool operator ==(Ids left, Ids right) => Equals(left, right);
 
 	public static bool operator !=(Ids left, Ids right) => !Equals(left, right);
+
+	#region IParsable
+
+	public static Ids Parse(string s, IFormatProvider? provider) =>
+		TryParse(s, provider, out var result) ? result : throw new FormatException();
+
+	public static bool TryParse([NotNullWhen(true)] string? s, IFormatProvider? provider,
+		[NotNullWhen(true)] out Ids? result)
+	{
+		if (s is null)
+		{
+			result = null;
+			return false;
+		}
+
+		if (s.IsNullOrEmptyCommaSeparatedList(out var list))
+		{
+			result = new Ids();
+			return true;
+		}
+
+		var ids = new List<Id>();
+		foreach (var item in list)
+		{
+			if (!Id.TryParse(item, provider, out var id))
+			{
+				result = null;
+				return false;
+			}
+
+			ids.Add(id);
+		}
+
+		result = new Ids(ids);
+		return true;
+	}
+
+	#endregion IParsable
 }