2.3 new API's feature parity

This commit adds support for the new 2.3 API's:

* tasks_list
* tasks_cancel
* update_by_query
* reindex

The spec changes have also been updated in core upstream.

The Reindex API is called `ReindexOnServer()` to offset it against our
current `Reindex()` implementation which is still very useful.

Both the reindex and update_by_query steal the status code from one of
the failures and return a valid json body that we need to deserialize.
To support this this AllowedStatusCodes now accepts a -1.

.IsValid for these API's inspects whether any failures have been
returned or not.

Author: Mpdreamz

src/CodeGeneration/CodeGeneration.LowLevelClient/ApiEndpoints/root.html

@@ -7,7 +7,7 @@
       "paths": ["/_tasks/_cancel", "/_tasks/{task_id}/_cancel"],
       "parts": {
         "task_id": {
-          "type": "number",
+          "type": "string",
           "description": "Cancel the task with specified id"
         }
       },
@@ -25,7 +25,7 @@
           "description": "Cancel tasks with specified parent node."
         },
         "parent_task": {
-          "type" : "number",
+          "type" : "string",
           "description" : "Cancel tasks with specified parent task id. Set to -1 to cancel all."
         }
       }

src/CodeGeneration/CodeGeneration.LowLevelClient/ApiEndpoints/tasks.cancel.json

@@ -7,7 +7,7 @@
       "paths": ["/_tasks", "/_tasks/{task_id}"],
       "parts": {
         "task_id": {
-          "type": "number",
+          "type": "string",
           "description": "Return the task with specified id"
         }
       },
@@ -29,7 +29,7 @@
           "description": "Return tasks with specified parent node."
         },
         "parent_task": {
-          "type" : "number",
+          "type" : "string",
           "description" : "Return tasks with specified parent task id. Set to -1 to return all."
         },
         "wait_for_completion": {

src/CodeGeneration/CodeGeneration.LowLevelClient/ApiEndpoints/tasks.list.json

@@ -8,6 +8,7 @@
       "comment": "most things below this are just copied from search.json",
       "parts": {
         "index": {
+         "required" : true,
          "type" : "list",
          "description" : "A comma-separated list of index names to search; use `_all` or empty string to perform the operation on all indices"
         },

src/CodeGeneration/CodeGeneration.LowLevelClient/ApiEndpoints/update_by_query.json

@@ -68,6 +68,7 @@
     <Compile Include="Overrides\Descriptors\PutIndexTemplateDescriptorOverrides.cs" />
     <Compile Include="Overrides\Descriptors\ScrollDescriptorOverrides.cs" />
     <Compile Include="Overrides\Descriptors\SearchDescriptorOverrides.cs" />
+    <Compile Include="Overrides\Descriptors\ReindexOnServerDescriptorOverrides.cs" />
     <Compile Include="Overrides\Descriptors\UpdateDescriptorOverrides.cs" />
     <Compile Include="Overrides\Global\GlobalQueryParameters.cs" />
     <Compile Include="Program.cs" />

src/CodeGeneration/CodeGeneration.LowLevelClient/CodeGeneration.LowLevelClient.csproj

@@ -19,9 +19,10 @@ public string CsharpType(string paramName)
 					return "bool";
 				case "list":
 					return "params string[]";
+				case "integer":
 				case "number":
-					return new [] {"boost", "percen", "score"}.Any(s=>paramName.ToLowerInvariant().Contains(s)) 
-						? "double" 
+					return new [] {"boost", "percen", "score"}.Any(s=>paramName.ToLowerInvariant().Contains(s))
+						? "double"
 						: "long";
 				case "duration":
 				case "time":
@@ -36,7 +37,7 @@ public string CsharpType(string paramName)
 					return this.Type;
 			}
 		}
-		
+
 		public string HighLevelType(string paramName)
 		{
 			var csharpType = this.CsharpType(paramName);
@@ -49,4 +50,4 @@ public string HighLevelType(string paramName)
 			}
 		}
 	}
-}
+}

src/CodeGeneration/CodeGeneration.LowLevelClient/Domain/ApiQueryParameters.cs

@@ -21,7 +21,7 @@ public string ClrTypeName
 					case "id": return this.Type == "string" ? "Id" : "Ids";
 					case "node_id": return this.Type == "string" ? "NodeId" : "NodeIds";
 					case "scroll_id": return this.Type == "string" ? "ScrollId" : "ScrollIds";
-					case "field": 
+					case "field":
 					case "fields": return this.Type == "string" ? "Field" : "Fields";
 					case "index_metric": return "IndexMetrics";
 					case "metric": return "Metrics";
@@ -30,6 +30,7 @@ public string ClrTypeName
 					case "snapshot":
 					case "lang":
 					case "name": return this.Type == "string" ? "Name" : "Names";
+					case "task_id": return "TaskId";
 					default: return this.Type + "_";
 				}
 			}
@@ -47,4 +48,4 @@ public string InterfaceName
 			}
 		}
 	}
-}
+}

src/CodeGeneration/CodeGeneration.LowLevelClient/Domain/ApiUrlPart.cs

@@ -120,7 +120,7 @@ public IEnumerable<Constructor> RequestConstructors()
 				{
 					var generic = this.RequestTypeGeneric.Replace("<", "").Replace(">", "");
 					generated = $"public {m}({par}) : this({cp.First().Key}, typeof({generic})){{}}";
-                }
+				}
 
 				var c = new Constructor { Generated = generated, Description = doc };
 				ctors.Add(c);

src/CodeGeneration/CodeGeneration.LowLevelClient/Domain/CsharpMethod.cs

@@ -0,0 +1,16 @@
+using System.Collections.Generic;
+
+namespace CodeGeneration.LowLevelClient.Overrides.Descriptors
+{
+	// ReSharper disable once UnusedMember.Global
+	public class ReindexOnServerDescriptorOverrides : IDescriptorOverrides
+	{
+		public IEnumerable<string> SkipQueryStringParams => new []
+		{
+			"source"
+		};
+
+		public IDictionary<string, string> RenameQueryStringParams => null;
+	}
+
+}

src/CodeGeneration/CodeGeneration.LowLevelClient/Overrides/Descriptors/ReindexOnServerDescriptorOverrides.cs

@@ -3545,32 +3545,28 @@ public class PutSearchTemplateRequestParameters : FluentRequestParameters<PutSea
 	///https://www.elastic.co/guide/en/elasticsearch/plugins/master/plugins-reindex.html
 	///</pre>
 	///</summary>
-	public class ReindexRequestParameters : FluentRequestParameters<ReindexRequestParameters> 
+	public class ReindexOnServerRequestParameters : FluentRequestParameters<ReindexOnServerRequestParameters> 
 	{
 		public override HttpMethod DefaultHttpMethod => HttpMethod.POST;
 
 		///<summary>Should the effected indexes be refreshed?</summary>
-		public ReindexRequestParameters Refresh(bool refresh) => this.AddQueryString("refresh", refresh);
+		public ReindexOnServerRequestParameters Refresh(bool refresh) => this.AddQueryString("refresh", refresh);
 
 
 		///<summary>Time each individual bulk request should wait for shards that are unavailable.</summary>
-		public ReindexRequestParameters Timeout(TimeSpan timeout) => this.AddQueryString("timeout", timeout.ToTimeUnit());
+		public ReindexOnServerRequestParameters Timeout(TimeSpan timeout) => this.AddQueryString("timeout", timeout.ToTimeUnit());
 
 
 		///<summary>Explicit write consistency setting for the operation</summary>
-		public ReindexRequestParameters Consistency(Consistency consistency) => this.AddQueryString("consistency", consistency);
+		public ReindexOnServerRequestParameters Consistency(Consistency consistency) => this.AddQueryString("consistency", consistency);
 
 
 		///<summary>Should the request should block until the reindex is complete.</summary>
-		public ReindexRequestParameters WaitForCompletion(bool wait_for_completion) => this.AddQueryString("wait_for_completion", wait_for_completion);
-		
-		
-		///<summary>The URL-encoded request definition</summary>
-		public ReindexRequestParameters Source(string source) => this.AddQueryString("source", source);
+		public ReindexOnServerRequestParameters WaitForCompletion(bool wait_for_completion) => this.AddQueryString("wait_for_completion", wait_for_completion);
 
 
 		///<summary>Comma separated list of filters used to reduce the response returned by Elasticsearch</summary>
-		public ReindexRequestParameters FilterPath(string filter_path) => this.AddQueryString("filter_path", filter_path);
+		public ReindexOnServerRequestParameters FilterPath(string filter_path) => this.AddQueryString("filter_path", filter_path);
 
 	}
 
@@ -4144,7 +4140,7 @@ public class TasksCancelRequestParameters : FluentRequestParameters<TasksCancelR
 
 
 		///<summary>Cancel tasks with specified parent task id. Set to -1 to cancel all.</summary>
-		public TasksCancelRequestParameters ParentTask(long parent_task) => this.AddQueryString("parent_task", parent_task);
+		public TasksCancelRequestParameters ParentTask(string parent_task) => this.AddQueryString("parent_task", parent_task);
 
 
 		///<summary>The URL-encoded request definition</summary>
@@ -4182,7 +4178,7 @@ public class TasksListRequestParameters : FluentRequestParameters<TasksListReque
 
 
 		///<summary>Return tasks with specified parent task id. Set to -1 to return all.</summary>
-		public TasksListRequestParameters ParentTask(long parent_task) => this.AddQueryString("parent_task", parent_task);
+		public TasksListRequestParameters ParentTask(string parent_task) => this.AddQueryString("parent_task", parent_task);
 
 
 		///<summary>Wait for the matching tasks to complete (default: false)</summary>
@@ -4504,7 +4500,7 @@ public class UpdateByQueryRequestParameters : FluentRequestParameters<UpdateByQu
 
 
 		///<summary>Size on the scroll request powering the update_by_query</summary>
-		public UpdateByQueryRequestParameters ScrollSize(integer scroll_size) => this.AddQueryString("scroll_size", scroll_size);
+		public UpdateByQueryRequestParameters ScrollSize(long scroll_size) => this.AddQueryString("scroll_size", scroll_size);
 
 
 		///<summary>Should the request should block until the reindex is complete.</summary>