How to extend the serializer in the latest version?

[gpetrou]

Once again there are breaking changes in a patch version.
Before the latest version, we had the following class:

internal class ExtendedSystemTextJsonSerializer : SystemTextJsonSerializer
{
    public ExtendedSystemTextJsonSerializer(IElasticsearchClientSettings elasticsearchClientSettings)
        : base(elasticsearchClientSettings)
    {
        JsonSerializerOptions options = DefaultSourceSerializer.CreateDefaultJsonSerializerOptions(includeDefaultConverters: true);

        options.Converters.Add(new ObjectConverter());

        Options = DefaultSourceSerializer.AddDefaultConverters(options);
    }

    protected JsonSerializerOptions Options { get; set; }

    protected override JsonSerializerOptions CreateJsonSerializerOptions() => Options;
}

We were calling it as in the following code:

ElasticsearchClientSettings elasticsearchClientSettings = new(
    nodePool,
    sourceSerializer: (defaultSerializer, settings) =>
        new ExtendedSystemTextJsonSerializer(settings));

How is this supposed to be transformed now in the latest version? We do not need the IElasticsearchClientSettings anymore?

[flobernd]

Hi @gpetrou,

This got even easier now:

ElasticsearchClientSettings elasticsearchClientSettings = new(
    nodePool,
    sourceSerializer: (defaultSerializer, settings) =>
        new DefaultSourceSerializer(settings, options => options.Converters.Add(/*...*/)));

Please let me know, if that answers your question.

PS: We still don't use semantic versioning.

[github-actions]

This issue is stale because it has been open 5 days with no activity. Remove stale label or comment or this will be closed in 2 days.

[github-actions]

This issue was closed because it has been stalled for 2 days with no activity.