Query operator handles null but no nullable in method siguature resulting in warnings

[tstojecki]

Any reason why these are not nullable types? The operator methods (.And() and .Or()) seem to be handling null args so it appears that nulls are allowed?

https://github.com/elastic/elasticsearch-net/blob/de0517da98ac751d15b8ea02fc901c4cbca0b0f0/src/Elastic.Clients.Elasticsearch/_Shared/Types/QueryDsl/Query.cs#L17C33-L17C39

Without this using Nullable results in a compile time warning unless pragma is used
# pragma warning disable CS8604

[flobernd]

Hi @tstojecki, this code was initially implemented at a time when nullability annotations did not exist and has never been refactored so far.

You could use the null forgiveness operator q1 & q2! instead of the pragma until we add the nullability annotations to the query operators.

[tstojecki]

Sounds good @flobernd - we will go go with a ! for now.

Also, while we were testing other approaches, passing an empty Query = new() results in an invalid query with an empty object {} like so

{"query":{"bool":{"must":[{"ids":...}, {} ]}}}

I know you might say - don't combine an empty query with another query - but I am not sure if there is any benefit and perhaps it's not too difficult to not modify the query in that instance - so an empty Query effectively behaves the same way as null Query - both do nothing.