Skip to content

Commit 2d689b2

Browse files
committed
Updated Breaking changes notes
1 parent 9150f71 commit 2d689b2

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

BREAKING_CHANGES.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,14 @@ The following functions has been removed:
3737
- `ClientBuilder::setSniffOnStart()`
3838
- `ClientBuilder::includePortInHostHeader()`
3939

40+
We removed the special `client` parameter passed in `$params` endpoints. In details:
41+
42+
- `$params['client']['never_retry']`
43+
- `$params['client']['verbose']`
44+
- `$params['client']['port_in_header']`
45+
- `$params['client']['future']`, you can set HTTP async using `Client::setAsync(true)`
46+
- `$params['client']['ignore']`, you can disable the Exception using `Client::setResponseException(false)`
47+
4048
# 7.17
4149

4250
- We changed the signature of `Elasticsearch\Common\EmptyLogger::log` adding the `void` return type.

README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,13 +93,14 @@ for HTTP client communications.
9393

9494
We tried to reduce the BC breaks as much as possible with `7.x` but there are some (big) differences:
9595

96-
- we changed the namespace, now everything is under `Elastic\Elasticsearch`;
96+
- we changed the namespace, now everything is under `Elastic\Elasticsearch`
9797
- we used the [elastic-transport-php](https://github.com/elastic/elastic-transport-php) library for HTTP communications;
9898
- we changed the `Exception` model, using the namespace `Elastic\Elasticsearch\Exception`. All the exceptions extends the
99-
`ElasticsearchException` interface, as in 7.x;
99+
`ElasticsearchException` interface, as in 7.x
100100
- we changed the response type of each endpoints using an [Elasticsearch](src/Response/Elasticsearch.php) response class.
101101
This class wraps a a [PSR-7](https://www.php-fig.org/psr/psr-7/) response allowing the access of the body response
102102
as array or object. This means you can access the API response as in 7.x, no BC break here! :angel:
103+
- we changed the `ConnectionPool` in `NodePool`. The `connection` naming was ambigous since the objects are nodes (hosts)
103104

104105
You can have a look at the [BREAKING_CHANGES](BREAKING_CHANGES.md) file for more information.
105106

0 commit comments

Comments
 (0)