Refactored phpstan config

Author: ezimuel

composer.json

@@ -55,11 +55,8 @@
       "phpcs --standard=ruleset.xml --extensions=php --encoding=utf-8 --tab-width=4 -sp src",
       "phpcs --standard=ruleset.xml --extensions=php --encoding=utf-8 --tab-width=4 -sp tests"
     ],
-    "phpstan7.1": [
-      "@php vendor/bin/phpstan analyse -c phpstan-src-71.neon src --level 2 --no-progress"
-    ],
     "phpstan": [
-      "@php vendor/bin/phpstan analyse -c phpstan-src.neon src --level 2 --no-progress"
+      "phpstan analyse src --level 2 --no-progress"
     ]
   }
 }

phpstan-src.neon

@@ -0,0 +1,3 @@
+parameters:
+    ignoreErrors:
+        - '#Unsafe usage of new static()#'

phpstan-tests.neon

@@ -342,7 +342,7 @@ public function setHosts(array $hosts): ClientBuilder
      *
      * @link https://www.elastic.co/guide/en/elasticsearch/reference/current/security-api-create-api-key.html
      *
-     * @throws Elasticsearch\Common\Exceptions\AuthenticationConfigException
+     * @throws AuthenticationConfigException
      */
     public function setApiKey(string $id, string $apiKey): ClientBuilder
     {
@@ -363,7 +363,7 @@ public function setApiKey(string $id, string $apiKey): ClientBuilder
      * @param string $username
      * @param string $password
      *
-     * @throws Elasticsearch\Common\Exceptions\AuthenticationConfigException
+     * @throws AuthenticationConfigException
      */
     public function setBasicAuthentication(string $username, string $password): ClientBuilder
     {

phpstan.neon

@@ -219,7 +219,7 @@ private function getOptionalType(): string
      */
     private function checkUserParams(array $params)
     {
-        if (isset($params) !== true) {
+        if (empty($params)) {
             return; //no params, just return.
         }
 

src/Elasticsearch/ClientBuilder.php

@@ -18,6 +18,10 @@
  */
 class SearchHitIteratorTest extends \PHPUnit\Framework\TestCase
 {
+    /**
+     * @var SearchResponseIterator
+     */
+    private $searchResponse;
 
     public function setUp()
     {

src/Elasticsearch/Endpoints/AbstractEndpoint.php

@@ -7,6 +7,7 @@
 use GitWrapper\GitWrapper;
 
 error_reporting(E_ALL | E_STRICT);
+use Elasticsearch\Tests\Utility;
 
 // Set the default timezone. While this doesn't cause any tests to fail, PHP
 // complains if it is not set in 'date.timezone' of php.ini.