Convert array parameter to comma-separated list of values

Author: ezimuel

src/Traits/EndpointTrait.php

@@ -27,6 +27,19 @@
 
 trait EndpointTrait
 {
+    /**
+     * Check if an array containts nested array
+     */
+    private function isNestedArray(array $a): bool
+    {
+        foreach ($a as $v) {
+            if (is_array($v)) {
+                return true;
+            }
+        }
+        return false;
+    }
+
     /**
      * Returns the URL with the query string from $params
      * extracting the array keys specified in $keys
@@ -36,7 +49,15 @@ protected function addQueryString(string $url, array $params, array $keys): stri
         $queryParams = [];
         foreach ($keys as $k) {
             if (isset($params[$k])) {
-                $queryParams[$k] = is_bool($params[$k]) ? ($params[$k] ? 'true' : 'false') : $params[$k];
+                // Convert to 'true' or 'false' string if bool
+                if (is_bool($params[$k])) {
+                    $queryParams[$k] = $params[$k] ? 'true' : 'false';
+                // Convert to comma-separated list if array
+                } elseif (is_array($params[$k]) && $this->isNestedArray($params[$k]) === false) {
+                    $queryParams[$k] = implode(',', $params[$k]);
+                } else {
+                    $queryParams[$k] = $params[$k];
+                }
             }
         }
         if (empty($queryParams)) {

tests/Integration/BasicTest.php

@@ -88,6 +88,29 @@ public function testIndexDocumentWithBodyAsString()
         return $response['_id']; 
     }
 
+    public function testIndexStatistics()
+    {
+        $response = $this->client->indices()->stats([
+            'index' => 'stocks',
+            'metric' => 'completion,docs'
+        ]);
+        $this->assertEquals(200, $response->getStatusCode());
+        $this->assertNotNull($response['_all']['primaries']['completion']);
+        $this->assertNotNull($response['_all']['primaries']['docs']);
+    }
+
+    public function testIndexStatisticsWithExpandWildcardsAsArray()
+    {
+        $response = $this->client->indices()->stats([
+            'index' => 'stocks',
+            'metric' => 'completion,docs',
+            'expand_wildcards' => ['open', 'closed']
+        ]);
+        $this->assertEquals(200, $response->getStatusCode());
+        $this->assertNotNull($response['_all']['primaries']['completion']);
+        $this->assertNotNull($response['_all']['primaries']['docs']);
+    }
+
     /**
      * @depends testIndexDocumentWithBodyAsString
      */