[CI] Test Runner: Adds node_selector to skipped features in YAML test runner

Author: picandocodigo

api-spec-testing/test_file/test.rb

@@ -219,8 +219,8 @@ def skip_test?(client, features_to_skip = test_file.features_to_skip)
           return true if pre_defined_skip?
 
           if @skip
-            @skip.collect { |s| s['skip'] }.any? do |skip|
-              contains_features_to_skip?(features_to_skip, skip) || test_file.skip_version?(client, skip)
+            @skip.collect { |s| s['skip'] }.any? do |skip_definition|
+              contains_features_to_skip?(features_to_skip, skip_definition) || test_file.skip_version?(client, skip_definition)
             end
           end
         end
@@ -244,8 +244,8 @@ def inject_master_node_id(expected_key)
 
         private
 
-        def contains_features_to_skip?(features_to_skip, skip_defintion)
-          !(features_to_skip &  ([skip_defintion['features']].flatten || [])).empty?
+        def contains_features_to_skip?(features_to_skip, skip_definition)
+          !(features_to_skip &  ([skip_definition['features']].flatten || [])).empty?
         end
 
         def pre_defined_skip?

elasticsearch-api/spec/rest_yaml_tests_helper.rb

@@ -94,10 +94,6 @@
 skipped_tests << { file:        'cat.templates/10_basic.yml',
                    description: '*' }
 
-# node_selector is not supported yet
-skipped_tests << { file: 'cat.aliases/10_basic.yml',
-                   description: '*' }
-
 # Responses are there but not equal (eg.: yellow status)
 skipped_tests << { file: 'cluster.health/10_basic.yml',
                    description: 'cluster health with closed index (pre 7.2.0)' }
@@ -112,4 +108,4 @@
 REST_API_YAML_FILES = SINGLE_TEST || Dir.glob("#{YAML_FILES_DIRECTORY}/**/*.yml")
 
 # The features to skip
-REST_API_YAML_SKIP_FEATURES = ['warnings'].freeze
+REST_API_YAML_SKIP_FEATURES = ['warnings', 'node_selector'].freeze

elasticsearch-xpack/spec/rest_yaml_tests_helper.rb

@@ -188,4 +188,4 @@
 REST_API_YAML_FILES = SINGLE_TEST || Dir.glob("#{YAML_FILES_DIRECTORY}/**/*.yml")
 
 # The features to skip
-REST_API_YAML_SKIP_FEATURES = ['warnings'].freeze
+REST_API_YAML_SKIP_FEATURES = ['warnings', 'node_selector'].freeze