Remove special handling for create and just use index endpoint

Author: estolfo

elasticsearch-api/lib/elasticsearch/api/actions/create.rb

@@ -48,7 +48,6 @@ def create(arguments = {})
         end
         request_opts[:defined_params] = defined_params unless defined_params.empty?
 
-        arguments.update endpoint: 'create'
         if arguments[:id]
           index arguments.update op_type: 'create'
         else

elasticsearch-api/spec/elasticsearch/api/perform_request_spec.rb

@@ -38,6 +38,10 @@
     let(:client_double) do
       Class.new { include Elasticsearch::API }.new.tap do |client|
         expect(client).to receive(:perform_request) do |_, _, _, _, _, request_params|
+          # The create method ends up becoming an 'index' request
+          if expected_perform_request_params[:endpoint] == 'create'
+            expected_perform_request_params[:endpoint] = 'index'
+          end
           # Check that the expected hash is passed to the perform_request method
           expect(request_params).to eq(expected_perform_request_params)
         end.and_return(response_double)

elasticsearch-api/utils/thor/templates/method.erb

@@ -34,7 +34,6 @@ module Elasticsearch
 <%- end %>
 <%-    %>
 <%- if @spec.endpoint_name == 'create' -%>
-  <%= '  '*(@spec.namespace_depth+3) %>arguments.update endpoint: 'create'
   <%= '  '*(@spec.namespace_depth+3) %>if arguments[:id]
   <%= '  '*(@spec.namespace_depth+3) %>  index arguments.update op_type: 'create'
   <%= '  '*(@spec.namespace_depth+3) %>else