Skip to content

Commit 158500f

Browse files
committed
Update client spec to check for adapter instead of handlers (Faraday 1.0)
1 parent bc0e4af commit 158500f

File tree

1 file changed

+35
-17
lines changed

1 file changed

+35
-17
lines changed

elasticsearch-transport/spec/elasticsearch/transport/client_spec.rb

Lines changed: 35 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -91,26 +91,41 @@
9191
describe 'adapter' do
9292
context 'when no adapter is specified' do
9393
let(:adapter) do
94-
client.transport.connections.all.first.connection.builder.handlers
94+
client.transport.connections.all.first.connection.builder.adapter
9595
end
9696

9797
it 'uses Faraday NetHttp' do
98-
expect(adapter).to include(Faraday::Adapter::NetHttp)
98+
expect(adapter).to eq Faraday::Adapter::NetHttp
9999
end
100100
end
101101

102102
context 'when the adapter is specified' do
103103

104104
let(:adapter) do
105-
client.transport.connections.all.first.connection.builder.handlers
105+
client.transport.connections.all.first.connection.builder.adapter
106106
end
107107

108108
let(:client) do
109-
described_class.new(adapter: :typhoeus)
109+
described_class.new(adapter: :patron)
110110
end
111111

112-
it 'uses Faraday' do
113-
expect(adapter).to include(Faraday::Adapter::Typhoeus)
112+
it 'uses Faraday with the adapter' do
113+
expect(adapter).to eq Faraday::Adapter::Patron
114+
end
115+
end
116+
117+
context 'when the adapter is specified as a string key' do
118+
119+
let(:adapter) do
120+
client.transport.connections.all.first.connection.builder.adapter
121+
end
122+
123+
let(:client) do
124+
described_class.new('adapter' => :patron)
125+
end
126+
127+
it 'uses Faraday with the adapter' do
128+
expect(adapter).to eq Faraday::Adapter::Patron
114129
end
115130
end
116131

@@ -122,29 +137,33 @@
122137
end
123138

124139
let(:adapter) do
125-
client.transport.connections.all.first.connection.builder.handlers
140+
client.transport.connections.all.first.connection.builder.adapter
126141
end
127142

128143
it 'uses the detected adapter' do
129-
expect(adapter).to include(Faraday::Adapter::Patron)
144+
expect(adapter).to eq Faraday::Adapter::Patron
130145
end
131146
end
132147

133148
context 'when the Faraday adapter is configured' do
134149

135150
let(:client) do
136151
described_class.new do |faraday|
137-
faraday.adapter :typhoeus
152+
faraday.adapter :patron
138153
faraday.response :logger
139154
end
140155
end
141156

157+
let(:adapter) do
158+
client.transport.connections.all.first.connection.builder.adapter
159+
end
160+
142161
let(:handlers) do
143162
client.transport.connections.all.first.connection.builder.handlers
144163
end
145164

146165
it 'sets the adapter' do
147-
expect(handlers).to include(Faraday::Adapter::Typhoeus)
166+
expect(adapter).to eq Faraday::Adapter::Patron
148167
end
149168

150169
it 'sets the logger' do
@@ -766,23 +785,22 @@
766785
end
767786

768787
context 'when the Faraday adapter is set in the block' do
769-
770788
let(:client) do
771789
Elasticsearch::Client.new(host: ELASTICSEARCH_HOSTS.first, logger: logger) do |client|
772790
client.adapter(:net_http_persistent)
773791
end
774792
end
775793

776-
let(:connection_handler) do
777-
client.transport.connections.first.connection.builder.handlers.first
794+
let(:handler_name) do
795+
client.transport.connections.first.connection.builder.adapter.name
778796
end
779797

780798
let(:response) do
781799
client.perform_request('GET', '_cluster/health')
782800
end
783801

784802
it 'sets the adapter' do
785-
expect(connection_handler.name).to eq('Faraday::Adapter::NetHttpPersistent')
803+
expect(handler_name).to eq('Faraday::Adapter::NetHttpPersistent')
786804
end
787805

788806
it 'uses the adapter to connect' do
@@ -981,12 +999,12 @@
981999
{ adapter: :patron }
9821000
end
9831001

984-
let(:connection_handler) do
985-
client.transport.connections.first.connection.builder.handlers.first
1002+
let(:adapter) do
1003+
client.transport.connections.first.connection.builder.adapter
9861004
end
9871005

9881006
it 'uses the patron connection handler' do
989-
expect(connection_handler).to eq('Faraday::Adapter::Patron')
1007+
expect(adapter).to eq('Faraday::Adapter::Patron')
9901008
end
9911009

9921010
it 'keeps connections open' do

0 commit comments

Comments
 (0)