[CLIENT] Converts all argument keys to symbol in Client initializer

picandocodigo · picandocodigo · commit 4518615d54d4 · 2020-08-27T14:25:20.000+01:00
diff --git a/elasticsearch-transport/lib/elasticsearch/transport/client.rb b/elasticsearch-transport/lib/elasticsearch/transport/client.rb
@@ -96,9 +96,9 @@ class Client
       #
       # @yield [faraday] Access and configure the `Faraday::Connection` instance directly with a block
       #
-      def initialize(arguments={}, &block)
-        @options = arguments
-        @arguments = arguments
+      def initialize(arguments = {}, &block)
+        @options = arguments.each_with_object({}){ |(k,v), args| args[k.to_sym] = v }
+        @arguments = @options
         @arguments[:logger] ||= @arguments[:log]   ? DEFAULT_LOGGER.call() : nil
         @arguments[:tracer] ||= @arguments[:trace] ? DEFAULT_TRACER.call() : nil
         @arguments[:reload_connections] ||= false

Original file line number	Diff line number	Diff line change
`@@ -96,9 +96,9 @@ class Client`
`96`	`96`	`#`
`97`	`97`	# @yield [faraday] Access and configure the `Faraday::Connection` instance directly with a block
`98`	`98`	`#`
`99`		`- def initialize(arguments={}, &block)`
`100`		`- @options = arguments`
`101`		`- @arguments = arguments`
	`99`	`+ def initialize(arguments = {}, &block)`
	`100`	`+ @options = arguments.each_with_object({}){ \|(k,v), args\| args[k.to_sym] = v }`
	`101`	`+ @arguments = @options`
`102`	`102`	`@arguments[:logger] \|\|= @arguments[:log] ? DEFAULT_LOGGER.call() : nil`
`103`	`103`	`@arguments[:tracer] \|\|= @arguments[:trace] ? DEFAULT_TRACER.call() : nil`
`104`	`104`	`@arguments[:reload_connections] \|\|= false`