[API] Refactors testing in elasticsearch-api

Reorganizes directories, removes unnecessary tests. Keeping a minimal integration test suite and
counting on YAML test runner for API coverage. Migrating minitest unit tests for api/actions to
RSpec.

Author: picandocodigo

elasticsearch-api/spec/platinum/integration/api_key/admin_user_query_api_keys_spec.rb renamed to elasticsearch-api/spec/integration/api_key_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Licensed to Elasticsearch B.V. under one or more contributor
 # license agreements. See the NOTICE file distributed with
 # this work for additional information regarding copyright
@@ -16,21 +18,21 @@
 # under the License.
 
 require 'base64'
-require_relative '../platinum_helper'
+require_relative './spec_helper'
 
 describe 'API keys' do
   before do
-    ADMIN_CLIENT.security.put_user(
+    CLIENT.security.put_user(
       username: client_username,
       body: { password: 'test-password', roles: ['superuser'] }
     )
   end
 
   after do
-    ADMIN_CLIENT.security.delete_user(username: client_username)
+    CLIENT.security.delete_user(username: client_username)
   end
 
-  let(:client_username) { "query_api_keys_#{Time.new.to_i}"}
+  let(:client_username) { "query_api_keys_#{Time.new.to_i}" }
   let(:credentials) { Base64.strict_encode64("#{client_username}:test-password") }
 
   let(:client) do
@@ -41,71 +43,71 @@
   end
 
   it 'queries API keys' do
-    key_name_1 = "query-key-1-#{Time.new.to_i}"
+    key_name1 = "query-key-1-#{Time.new.to_i}"
     response = client.security.create_api_key(
       body: {
-        name: key_name_1,
+        name: key_name1,
         role_descriptors: {},
-        expiration: "1d",
-        metadata: { search: "this" }
+        expiration: '1d',
+        metadata: { search: 'this' }
       }
     )
-    expect(response['name']).to eq key_name_1
+    expect(response['name']).to eq key_name1
     expect(response['api_key']).not_to be nil
-    api_key_id_1 = response['id']
+    api_key_id1 = response['id']
 
-    key_name_2 = "query-key-2-#{Time.new.to_i}"
+    key_name2 = "query-key-2-#{Time.new.to_i}"
     response = client.security.create_api_key(
       body: {
-        name: key_name_2,
-        expiration: "2d",
-        role_descriptors: { "role-a" => { "cluster": [ "monitor"] } },
+        name: key_name2,
+        expiration: '2d',
+        role_descriptors: { 'role-a' => { "cluster": ['monitor'] } },
         metadata: { search: false }
       }
     )
-    expect(response['name']).to eq key_name_2
+    expect(response['name']).to eq key_name2
     expect(response['api_key']).not_to be nil
-    api_key_id_2 = response['id']
+    api_key_id2 = response['id']
 
-    key_name_3 = "query-key-3#{Time.new.to_i}"
+    key_name3 = "query-key-3#{Time.new.to_i}"
     response = client.security.create_api_key(
       body: {
-        name: key_name_3,
-        expiration: "3d",
+        name: key_name3,
+        expiration: '3d'
       }
     )
-    expect(response['name']).to eq key_name_3
+    expect(response['name']).to eq key_name3
     expect(response['api_key']).not_to be nil
-    api_key_id_3 = response['id']
+    api_key_id3 = response['id']
 
     response = client.security.authenticate
-    owner_name = response['username']
+    response['username']
 
     response = client.security.query_api_keys(
       body: {
-        query: { wildcard: { name: key_name_1 }}
+        query: { wildcard: { name: key_name1 } }
       }
     )
     expect(response['total']).to eq 1
     expect(response['count']).to eq 1
-    expect(response['api_keys'].first['id']).to eq api_key_id_1
+    expect(response['api_keys'].first['id']).to eq api_key_id1
 
     response = client.security.query_api_keys(
       body: {
-        query: { wildcard: { name: key_name_2 }}
+        query: { wildcard: { name: key_name2 } }
       }
     )
     expect(response['total']).to eq 1
     expect(response['count']).to eq 1
-    expect(response['api_keys'].first['id']).to eq api_key_id_2
+    expect(response['api_keys'].first['id']).to eq api_key_id2
 
     response = client.security.query_api_keys(
       body: {
-        query: { wildcard: { name: key_name_3 }}
+        query: { wildcard: { name: key_name3 } }
       }
     )
     expect(response['total']).to eq 1
     expect(response['count']).to eq 1
-    expect(response['api_keys'].first['id']).to eq api_key_id_3
+    expect(response['api_keys'].first['id']).to eq api_key_id3
   end
 end

elasticsearch-api/spec/platinum/integration/health/health_spec.rb renamed to elasticsearch-api/spec/integration/health_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Licensed to Elasticsearch B.V. under one or more contributor
 # license agreements. See the NOTICE file distributed with
 # this work for additional information regarding copyright
@@ -15,12 +17,20 @@
 # specific language governing permissions and limitations
 # under the License.
 
-require_relative '../platinum_helper'
+require_relative './spec_helper'
+
+describe 'Health basic test' do
+  it 'performs the request' do
+    response = CLIENT.health_report
+    expect(response.status).to eq 200
+    expect(response['cluster_name']).not_to be_nil
+    expect(response.dig('indicators', 'master_is_stable', 'symptom')).to eq 'The cluster has a stable master node'
+    expect(response.dig('indicators', 'master_is_stable', 'status')).to eq 'green'
+  end
 
-describe 'Health API' do
   context 'Usage stats on the health API' do
     before do
-      ADMIN_CLIENT.indices.create(
+      CLIENT.indices.create(
         index: 'red_index',
         body: {
           settings: {
@@ -33,13 +43,13 @@
     end
 
     after do
-      ADMIN_CLIENT.indices.delete(index: 'red_index')
+      CLIENT.indices.delete(index: 'red_index')
     end
 
     it 'responds with health report' do
-      expect(ADMIN_CLIENT.health_report.status).to eq 200
-      expect(ADMIN_CLIENT.health_report(feature: 'disk').status).to eq 200
-      response = ADMIN_CLIENT.xpack.usage
+      expect(CLIENT.health_report.status).to eq 200
+      expect(CLIENT.health_report(feature: 'disk').status).to eq 200
+      response = CLIENT.xpack.usage
       expect(response['health_api']['available']).to eq true
       expect(response['health_api']['enabled']).to eq true
       expect(response['health_api']['invocations']['total']).to be >= 2

elasticsearch-api/spec/platinum/integration/platinum_helper.rb renamed to elasticsearch-api/spec/integration/spec_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Licensed to Elasticsearch B.V. under one or more contributor
 # license agreements. See the NOTICE file distributed with
 # this work for additional information regarding copyright
@@ -14,13 +16,11 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-
 require 'openssl'
 require 'elasticsearch'
 
-CERTS_PATH = File.expand_path('./../.buildkite/certs')
-
-host = ENV['TEST_ES_SERVER'] || 'https://localhost:9200'
+CERTS_PATH = File.expand_path('./../../../.buildkite/certs', __dir__)
+host = ENV['TEST_ES_SERVER'] || 'http://localhost:9200'
 raise URI::InvalidURIError unless host =~ /\A#{URI::DEFAULT_PARSER.make_regexp}\z/
 
 password = ENV['ELASTIC_PASSWORD'] || 'changeme'
@@ -31,12 +31,11 @@
 key = OpenSSL::PKey::RSA.new(raw_key)
 ca_file = File.expand_path("#{CERTS_PATH}/ca.crt")
 TRANSPORT_OPTIONS = { ssl: { verify: false, client_cert: certificate, client_key: key, ca_file: ca_file } }
-HOST = "https://elastic:#{password}@#{HOST_URI.host}:#{HOST_URI.port}".freeze
-
-ADMIN_CLIENT = Elasticsearch::Client.new(host: HOST, transport_options: TRANSPORT_OPTIONS)
+HOST = "https://elastic:#{password}@#{HOST_URI.host}:#{HOST_URI.port}"
+CLIENT = Elasticsearch::Client.new(host: HOST, transport_options: TRANSPORT_OPTIONS)
 
 RSpec.configure do |config|
   config.add_formatter('documentation')
-  config.add_formatter('RSpec::Core::Formatters::HtmlFormatter', "tmp/platinum-#{ENV['RUBY_VERSION']}-manual-integration.html")
+  config.add_formatter('RSpec::Core::Formatters::HtmlFormatter', "tmp/#{ENV['RUBY_VERSION']}-manual-integration.html")
   config.color_mode = :on
 end