[Gem] Updates tagline tests

Author: picandocodigo

elasticsearch/lib/elasticsearch.rb

@@ -20,9 +20,9 @@
 require 'elasticsearch/api'
 
 module Elasticsearch
-  SECURITY_PRIVILEGES_VALIDATION_WARNING = 'The client is unable to verify that the server is Elasticsearch due to security privileges on the server side.'.freeze
+  SECURITY_PRIVILEGES_VALIDATION_WARNING = 'The client is unable to verify that the server is Elasticsearch due to security privileges on the server side. Some functionality may not be compatible if the server is running an unsupported product.'.freeze
   NOT_ELASTICSEARCH_WARNING = 'The client noticed that the server is not Elasticsearch and we do not support this unknown product.'.freeze
-  YOU_KNOW_FOR_SEARCH = 'You know, for Search'.freeze
+  YOU_KNOW_FOR_SEARCH = 'You Know, for Search'.freeze
 
   class Client
     include Elasticsearch::API

elasticsearch/spec/unit/elasticsearch_product_validation_spec.rb

@@ -105,6 +105,7 @@ def valid_requests_and_expectations
           'content-type' => 'json'
         }
       end
+
       it 'Makes requests and passes validation' do
         verify_request_stub
         count_request_stub
@@ -134,6 +135,7 @@ def valid_requests_and_expectations
           'content-type' => 'json'
         }
       end
+
       it 'Makes requests and passes validation' do
         verify_request_stub
         count_request_stub
@@ -242,14 +244,33 @@ def valid_requests_and_expectations
       end
     end
 
+    context 'When the tagline is different' do
+      let(:body) do
+        {
+          'version' => {
+            'number' => '7.4.0',
+            'build_flavor' => 'default'
+          },
+          'tagline' => 'You Know, for other stuff'
+        }.to_json
+      end
+
+      it 'Fails validation' do
+        verify_request_stub
+        count_request_stub
+
+        error_requests_and_expectations
+      end
+    end
+
     context 'With a valid Elasticsearch response' do
       let(:body) do
         {
           'version' => {
             'number' => '7.4.0',
             'build_flavor' => 'default'
           },
-          'tagline' => Elasticsearch::YOU_KNOW_FOR_SEARCH
+          'tagline' => 'You Know, for Search'
         }.to_json
       end
 
@@ -286,7 +307,7 @@ def valid_requests_and_expectations
           'version' => {
             'number' => '6.8.10'
           },
-          'tagline' => Elasticsearch::YOU_KNOW_FOR_SEARCH
+          'tagline' => 'You Know, for Search'
         }.to_json
       end
 
@@ -310,6 +331,25 @@ def valid_requests_and_expectations
         error_requests_and_expectations
       end
     end
+
+    context 'When the tagline is different' do
+      let(:body) do
+        {
+          'version' => {
+            'number' => '6.8.10',
+            'build_flavor' => 'default'
+          },
+          'tagline' => 'You Know, for Stuff'
+        }.to_json
+      end
+
+      it 'Fails validation' do
+        verify_request_stub
+        count_request_stub
+
+        error_requests_and_expectations
+      end
+    end
   end
 
   context 'When Elasticsearch version is between 7.0.0 and 7.14.0' do
@@ -320,7 +360,7 @@ def valid_requests_and_expectations
             'number' => '7.10.0',
             'build_flavor' => 'default'
           },
-          'tagline' => Elasticsearch::YOU_KNOW_FOR_SEARCH
+          'tagline' => 'You Know, for Search'
         }.to_json
       end
 
@@ -350,13 +390,32 @@ def valid_requests_and_expectations
       end
     end
 
+    context 'When the tagline is different' do
+      let(:body) do
+        {
+          'version' => {
+            'number' => '7.10.0',
+            'build_flavor' => 'default'
+          },
+          'tagline' => 'You Know, for other stuff'
+        }.to_json
+      end
+
+      it 'Fails validation' do
+        verify_request_stub
+        count_request_stub
+
+        error_requests_and_expectations
+      end
+    end
+
     context 'When the build_flavor is not present' do
       let(:body) do
         {
           'version' => {
             'number' => '7.10.0'
           },
-          'tagline' => Elasticsearch::YOU_KNOW_FOR_SEARCH
+          'tagline' => 'You Know, for Search'
         }.to_json
       end