Don't use fake.com for tests

Author: picandocodigo

elasticsearch-transport/lib/elasticsearch/transport/client.rb

@@ -98,7 +98,7 @@ def initialize(arguments={}, &block)
         @arguments[:randomize_hosts]    ||= false
         @arguments[:transport_options]  ||= {}
         @arguments[:http]               ||= {}
-        @options[:http]               ||= {}
+        @options[:http]                 ||= {}
 
         @seeds = __extract_hosts(@arguments[:hosts] ||
                                      @arguments[:host] ||

elasticsearch-transport/spec/elasticsearch/transport/base_spec.rb

@@ -18,11 +18,8 @@
 require 'spec_helper'
 
 describe Elasticsearch::Transport::Transport::Base do
-
   context 'when a host is printed in a logged message' do
-
     shared_examples_for 'a redacted string' do
-
       let(:client) do
         Elasticsearch::Transport::Client.new(arguments)
       end
@@ -33,6 +30,7 @@
 
       it 'does not include the password in the logged string' do
         expect(logger).not_to receive(:error).with(/secret_password/)
+
         expect {
           client.cluster.stats
         }.to raise_exception(Faraday::ConnectionFailed)
@@ -47,7 +45,6 @@
     end
 
     context 'when the user and password are provided as separate arguments' do
-
       let(:arguments) do
         { hosts: 'fake',
           logger: logger,
@@ -59,19 +56,17 @@
     end
 
     context 'when the user and password are provided in the string URI' do
-
       let(:arguments) do
-        { hosts: 'http://test:secret_password@fake.com',
+        { hosts: 'https://test:secret_password@fake_local_elasticsearch',
           logger: logger }
       end
 
       it_behaves_like 'a redacted string'
     end
 
     context 'when the user and password are provided in the URI object' do
-
       let(:arguments) do
-        { hosts: URI.parse('http://test:secret_password@fake.com'),
+        { hosts: URI.parse('https://test:secret_password@fake_local_elasticsearch'),
           logger: logger }
       end