Skip to content

Commit f484c4f

Browse files
committed
[API] Reorganizes query_rule and query_ruleset into query_rules
1 parent b8b11eb commit f484c4f

File tree

15 files changed

+47
-49
lines changed

15 files changed

+47
-49
lines changed

elasticsearch-api/lib/elasticsearch/api.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,13 +82,12 @@ def self.included(base)
8282
Elasticsearch::API::XPack,
8383
Elasticsearch::API::SearchApplication,
8484
Elasticsearch::API::Synonyms,
85-
Elasticsearch::API::QueryRuleset,
8685
Elasticsearch::API::Esql,
8786
Elasticsearch::API::Inference,
8887
Elasticsearch::API::Profiling,
8988
Elasticsearch::API::Simulate,
9089
Elasticsearch::API::Connector,
91-
Elasticsearch::API::QueryRule
90+
Elasticsearch::API::QueryRules
9291
end
9392

9493
# The serializer class

elasticsearch-api/lib/elasticsearch/api/actions/query_rule/delete.rb renamed to elasticsearch-api/lib/elasticsearch/api/actions/query_rules/delete_rule.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#
2121
module Elasticsearch
2222
module API
23-
module QueryRule
23+
module QueryRules
2424
module Actions
2525
# Deletes an individual query rule within a ruleset.
2626
#
@@ -30,8 +30,8 @@ module Actions
3030
#
3131
# @see https://www.elastic.co/guide/en/elasticsearch/reference/current/delete-query-rule.html
3232
#
33-
def delete(arguments = {})
34-
request_opts = { endpoint: arguments[:endpoint] || 'query_rule.delete' }
33+
def delete_rule(arguments = {})
34+
request_opts = { endpoint: arguments[:endpoint] || 'query_rules.delete_rule' }
3535

3636
defined_params = %i[ruleset_id rule_id].each_with_object({}) do |variable, set_variables|
3737
set_variables[variable] = arguments[variable] if arguments.key?(variable)

elasticsearch-api/lib/elasticsearch/api/actions/query_ruleset/delete.rb renamed to elasticsearch-api/lib/elasticsearch/api/actions/query_rules/delete_ruleset.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#
2121
module Elasticsearch
2222
module API
23-
module QueryRuleset
23+
module QueryRules
2424
module Actions
2525
# Deletes a query ruleset.
2626
#
@@ -29,8 +29,8 @@ module Actions
2929
#
3030
# @see https://www.elastic.co/guide/en/elasticsearch/reference/current/delete-query-ruleset.html
3131
#
32-
def delete(arguments = {})
33-
request_opts = { endpoint: arguments[:endpoint] || 'query_ruleset.delete' }
32+
def delete_ruleset(arguments = {})
33+
request_opts = { endpoint: arguments[:endpoint] || 'query_rules.delete_ruleset' }
3434

3535
defined_params = [:ruleset_id].each_with_object({}) do |variable, set_variables|
3636
set_variables[variable] = arguments[variable] if arguments.key?(variable)

elasticsearch-api/lib/elasticsearch/api/actions/query_rule/get.rb renamed to elasticsearch-api/lib/elasticsearch/api/actions/query_rules/get_rule.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#
2121
module Elasticsearch
2222
module API
23-
module QueryRule
23+
module QueryRules
2424
module Actions
2525
# Returns the details about an individual query rule within a ruleset.
2626
#
@@ -30,8 +30,8 @@ module Actions
3030
#
3131
# @see https://www.elastic.co/guide/en/elasticsearch/reference/current/get-query-rule.html
3232
#
33-
def get(arguments = {})
34-
request_opts = { endpoint: arguments[:endpoint] || 'query_rule.get' }
33+
def get_rule(arguments = {})
34+
request_opts = { endpoint: arguments[:endpoint] || 'query_rules.get_rule' }
3535

3636
defined_params = %i[ruleset_id rule_id].each_with_object({}) do |variable, set_variables|
3737
set_variables[variable] = arguments[variable] if arguments.key?(variable)

elasticsearch-api/lib/elasticsearch/api/actions/query_ruleset/get.rb renamed to elasticsearch-api/lib/elasticsearch/api/actions/query_rules/get_ruleset.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#
2121
module Elasticsearch
2222
module API
23-
module QueryRuleset
23+
module QueryRules
2424
module Actions
2525
# Returns the details about a query ruleset.
2626
#
@@ -29,8 +29,8 @@ module Actions
2929
#
3030
# @see https://www.elastic.co/guide/en/elasticsearch/reference/current/get-query-ruleset.html
3131
#
32-
def get(arguments = {})
33-
request_opts = { endpoint: arguments[:endpoint] || 'query_ruleset.get' }
32+
def get_ruleset(arguments = {})
33+
request_opts = { endpoint: arguments[:endpoint] || 'query_rules.get_ruleset' }
3434

3535
defined_params = [:ruleset_id].each_with_object({}) do |variable, set_variables|
3636
set_variables[variable] = arguments[variable] if arguments.key?(variable)

elasticsearch-api/lib/elasticsearch/api/actions/query_ruleset/list.rb renamed to elasticsearch-api/lib/elasticsearch/api/actions/query_rules/list_rulesets.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#
2121
module Elasticsearch
2222
module API
23-
module QueryRuleset
23+
module QueryRules
2424
module Actions
2525
# Lists query rulesets.
2626
#
@@ -30,8 +30,8 @@ module Actions
3030
#
3131
# @see https://www.elastic.co/guide/en/elasticsearch/reference/current/list-query-rulesets.html
3232
#
33-
def list(arguments = {})
34-
request_opts = { endpoint: arguments[:endpoint] || 'query_ruleset.list' }
33+
def list_rulesets(arguments = {})
34+
request_opts = { endpoint: arguments[:endpoint] || 'query_rules.list_rulesets' }
3535

3636
arguments = arguments.clone
3737
headers = arguments.delete(:headers) || {}

elasticsearch-api/lib/elasticsearch/api/actions/query_rule/put.rb renamed to elasticsearch-api/lib/elasticsearch/api/actions/query_rules/put_rule.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#
2121
module Elasticsearch
2222
module API
23-
module QueryRule
23+
module QueryRules
2424
module Actions
2525
# Creates or updates a query rule within a ruleset.
2626
#
@@ -31,8 +31,8 @@ module Actions
3131
#
3232
# @see https://www.elastic.co/guide/en/elasticsearch/reference/current/put-query-rule.html
3333
#
34-
def put(arguments = {})
35-
request_opts = { endpoint: arguments[:endpoint] || 'query_rule.put' }
34+
def put_rule(arguments = {})
35+
request_opts = { endpoint: arguments[:endpoint] || 'query_rules.put_rule' }
3636

3737
defined_params = %i[ruleset_id rule_id].each_with_object({}) do |variable, set_variables|
3838
set_variables[variable] = arguments[variable] if arguments.key?(variable)

elasticsearch-api/lib/elasticsearch/api/actions/query_ruleset/put.rb renamed to elasticsearch-api/lib/elasticsearch/api/actions/query_rules/put_ruleset.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#
2121
module Elasticsearch
2222
module API
23-
module QueryRuleset
23+
module QueryRules
2424
module Actions
2525
# Creates or updates a query ruleset.
2626
#
@@ -30,8 +30,8 @@ module Actions
3030
#
3131
# @see https://www.elastic.co/guide/en/elasticsearch/reference/current/put-query-ruleset.html
3232
#
33-
def put(arguments = {})
34-
request_opts = { endpoint: arguments[:endpoint] || 'query_ruleset.put' }
33+
def put_ruleset(arguments = {})
34+
request_opts = { endpoint: arguments[:endpoint] || 'query_rules.put_ruleset' }
3535

3636
defined_params = [:ruleset_id].each_with_object({}) do |variable, set_variables|
3737
set_variables[variable] = arguments[variable] if arguments.key?(variable)

elasticsearch-api/lib/elasticsearch/api/namespace/query_rule.rb renamed to elasticsearch-api/lib/elasticsearch/api/namespace/query_rules.rb

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,19 +17,19 @@
1717

1818
module Elasticsearch
1919
module API
20-
module QueryRule
20+
module QueryRules
2121
module Actions; end
2222

23-
# Client for the "query_rule" namespace (includes the {QueryRule::Actions} methods)
23+
# Client for the "query_rules" namespace (includes the {QueryRules::Actions} methods)
2424
#
25-
class QueryRuleClient
26-
include Common::Client, Common::Client::Base, QueryRule::Actions
25+
class QueryRulesClient
26+
include Common::Client, Common::Client::Base, QueryRules::Actions
2727
end
2828

29-
# Proxy method for {QueryRuleClient}, available in the receiving object
29+
# Proxy method for {QueryRulesClient}, available in the receiving object
3030
#
31-
def query_rule
32-
@query_rule ||= QueryRuleClient.new(self)
31+
def query_rules
32+
@query_rules ||= QueryRulesClient.new(self)
3333
end
3434
end
3535
end

elasticsearch-api/spec/elasticsearch/api/actions/query_ruleset/delete_spec.rb renamed to elasticsearch-api/spec/elasticsearch/api/actions/query_rules/delete_ruleset_spec.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
require 'spec_helper'
1919

20-
describe 'client.query_ruleset#delete' do
20+
describe 'client.query_rules#delete_ruleset' do
2121

2222
let(:expected_args) do
2323
[
@@ -26,11 +26,11 @@
2626
{},
2727
nil,
2828
{},
29-
{ defined_params: { ruleset_id: 'foo' }, endpoint: 'query_ruleset.delete' }
29+
{ defined_params: { ruleset_id: 'foo' }, endpoint: 'query_rules.delete_ruleset' }
3030
]
3131
end
3232

3333
it 'performs the request' do
34-
expect(client_double.query_ruleset.delete(ruleset_id: 'foo')).to be_a Elasticsearch::API::Response
34+
expect(client_double.query_rules.delete_ruleset(ruleset_id: 'foo')).to be_a Elasticsearch::API::Response
3535
end
3636
end

0 commit comments

Comments
 (0)