Skip to content

Commit f745edd

Browse files
committed
[Test Runner] Check for to_s keys when injecting in response
1 parent f4f88f9 commit f745edd

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

elasticsearch-api/api-spec-testing/rspec_matchers.rb

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,17 +77,16 @@
7777
RSpec::Matchers.define :match_gte_field do |expected_pairs, test|
7878
match do |response|
7979
expected_pairs.all? do |expected_key, expected_value|
80-
8180
split_key = TestFile::Test.split_and_parse_key(expected_key).collect do |k|
8281
test.get_cached_value(k)
8382
end
84-
actual_value = split_key.inject(response) do |_response, key|
8583

84+
actual_value = split_key.inject(response) do |_response, key|
8685
# If the key is an index, indicating element of a list
8786
if _response.empty? && key == '$body'
8887
_response
8988
else
90-
_response[key] || _response[key]
89+
_response[key] || _response[key.to_s]
9190
end
9291
end
9392
actual_value >= test.get_cached_value(expected_value)

elasticsearch-api/api-spec-testing/test_file/test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ def split_and_parse_key(key)
6161
key.split(/(?<!\\)\./).reject(&:empty?).map do |key_part|
6262
case key_part
6363
when /^\.\$/ # For keys in the form of .$key
64-
key_part.gsub(/^\./, '')
64+
key_part.gsub(/^\./, '')
6565
when /\A[-+]?[0-9]+\z/
6666
key_part.to_i
6767
else

0 commit comments

Comments
 (0)