Fix tests

Author: pquentin

compiler/src/model/utils.ts

@@ -654,11 +654,6 @@ export function hoistRequestAnnotations (
   const endpoint = mappings[apiName]
   assert(jsDocs, endpoint != null, `The api '${apiName}' does not exists, did you mean '${closest(apiName, Object.keys(mappings))}'?`)
 
-  if (endpoint.availability.stack?.visibility !== 'private') {
-    assert(jsDocs, tags.doc_id !== '' && tags.doc_id !== null && tags.doc_id !== undefined,
-      `Request ${request.name.name} needs a @doc_id annotation`)
-  }
-
   endpoint.request = request.name
   endpoint.response = response
 
@@ -729,6 +724,11 @@ export function hoistRequestAnnotations (
       assert(jsDocs, false, `Unhandled tag: '${tag}' with value: '${value}' on request ${request.name.name}`)
     }
   })
+
+  if (endpoint.availability.stack?.visibility !== 'private') {
+    assert(jsDocs, tags.doc_id !== '' && tags.doc_id !== null && tags.doc_id !== undefined,
+      `Request ${request.name.name} needs a @doc_id annotation`)
+  }
 }
 
 /** Lifts jsDoc type annotations to fixed properties on Type */

compiler/test/body-codegen-name/specification/_global/index/request.ts

@@ -20,6 +20,7 @@
 /**
  * @rest_spec_name index
  * @availability stack since=0.0.0 stability=stable
+ * @doc_id docs-index
  */
 export interface Request {
   body: Foo

compiler/test/duplicate-body-codegen-name/specification/_global/index/request.ts

@@ -20,6 +20,7 @@
 /**
  * @rest_spec_name index
  * @availability stack since=0.0.0 stability=stable
+ * @doc_id docs-index
  */
 export interface Request {
   path_parts: {

compiler/test/no-body/specification/_global/info/request.ts

@@ -20,6 +20,7 @@
 /**
  * @rest_spec_name info
  * @availability stack since=0.0.0 stability=stable
+ * @doc_id api-root
  */
 export interface Request {
   body: {

compiler/test/request-availability/specification/_global/index/request.ts

@@ -21,6 +21,7 @@
  * @rest_spec_name index
  * @availability serverless visibility=private stability=experimental
  * @availability stack stability=beta since=1.2.3 visibility=feature_flag feature_flag=abc
+ * @doc_id docs-index
  */
 export interface Request<TDocument> {
   path_parts: {

compiler/test/request-fields/specification/_global/index/request.ts

@@ -20,6 +20,7 @@
 /**
  * @rest_spec_name index
  * @availability stack stability=stable since=0.0.0
+ * @doc_id docs-index
  */
 export interface Request<TDocument> {
   path_parts: {

compiler/test/types/specification/_global/info/request.ts

@@ -20,5 +20,6 @@
 /**
  * @rest_spec_name info
  * @availability stack since=0.0.0 stability=stable
+ * @doc_id api-root
  */
 export interface Request {}

compiler/test/types/test.ts

@@ -92,7 +92,7 @@ test('type_alias', t => {
 test('request', t => {
   const definition = model.types.find(t => t.kind === 'request') as Model.Request
   t.assert(definition)
-  t.true(definition?.specLocation.endsWith('test/types/specification/_global/info/request.ts#L20-L24'))
+  t.true(definition?.specLocation.endsWith('test/types/specification/_global/info/request.ts#L20-L25'))
   t.deepEqual(definition?.name, {
     name: 'Request',
     namespace: '_global.info'

compiler/test/writes-to-output/specification/_global/index/request.ts

@@ -20,5 +20,6 @@
 /**
  * @rest_spec_name index
  * @availability stack since=0.0.0 stability=stable
+ * @doc_id docs-index
  */
 export interface Request {}

compiler/test/wrong-namespace/specification/_global/foobar/request.ts

@@ -20,5 +20,6 @@
 /**
  * @rest_spec_name info
  * @availability stack since=0.0.0 stability=stable
+ * @doc_id api-root
  */
 export interface Request {}