Fail on unknown cases

pquentin · pquentin · commit 5e41093f53ef · 2025-11-19T10:03:19.000+04:00
diff --git a/compiler-rs/clients_schema_to_rest_api_spec/src/lib.rs b/compiler-rs/clients_schema_to_rest_api_spec/src/lib.rs
@@ -329,11 +329,11 @@ fn get_type_name(value_of: &ValueOf, types: &IndexMap<TypeName, TypeDefinition>)
                                 return literal;
                             }
                         }
-                        _ => todo!(),
+                        _ => panic!("Expected UnionOf or InstanceOf but got {:?}", alias.typ),
                     },
                     _ => panic!("Expected TypeAlias but got {:?}", full_type),
                 }
-                return "???".to_string();
+                panic!("Unhandled type: {:?}", full_type);
             }
         }
         _ => todo!(),

Original file line number	Diff line number	Diff line change
`@@ -329,11 +329,11 @@ fn get_type_name(value_of: &ValueOf, types: &IndexMap<TypeName, TypeDefinition>)`
`329`	`329`	`return literal;`
`330`	`330`	`}`
`331`	`331`	`}`
`332`		`- _ => todo!(),`
	`332`	`+ _ => panic!("Expected UnionOf or InstanceOf but got {:?}", alias.typ),`
`333`	`333`	`},`
`334`	`334`	`_ => panic!("Expected TypeAlias but got {:?}", full_type),`
`335`	`335`	`}`
`336`		`- return "???".to_string();`
	`336`	`+ panic!("Unhandled type: {:?}", full_type);`
`337`	`337`	`}`
`338`	`338`	`}`
`339`	`339`	`_ => todo!(),`