chore: add eslint rule no-duplicate-class-names

Author: MattDevy

output/openapi/elasticsearch-openapi.json

@@ -1,7 +1,6 @@
 {
   "endpointErrors": {},
   "generalErrors": [
-    "ResponseBody is present in multiple namespaces: _global.search and ml.evaluate_data_frame",
     "Dangling type '_global.scripts_painless_execute:PainlessExecutionPosition'",
     "Dangling type '_global.scripts_painless_execute:PainlessScript'",
     "Dangling type '_global.search._types:HitMetadata'",

output/openapi/elasticsearch-serverless-openapi.json

@@ -39,6 +39,64 @@ export default defineConfig({
     'es-spec-validator/request-must-have-urls': 'error',
     'es-spec-validator/no-variants-on-responses': 'error',
     'es-spec-validator/no-inline-unions': 'error',
-    'es-spec-validator/prefer-tagged-variants': 'error'
+    'es-spec-validator/prefer-tagged-variants': 'error',
+    'es-spec-validator/no-duplicate-type-names': [
+      'error',
+      {
+        ignoreNames: ['Request', 'Response', 'ResponseBase'],
+        existingDuplicates: {
+          Action: [
+            'indices.modify_data_stream',
+            'indices.update_aliases',
+            'watcher._types'
+          ],
+          Actions: ['ilm._types', 'security.put_privileges', 'watcher._types'],
+          ComponentTemplate: ['cat.component_templates', 'cluster._types'],
+          Context: [
+            '_global.get_script_context',
+            '_global.search._types',
+            'nodes._types'
+          ],
+          DatabaseConfigurationMetadata: [
+            'ingest.get_geoip_database',
+            'ingest.get_ip_location_database'
+          ],
+          Datafeed: ['ml._types', 'xpack.usage'],
+          Destination: ['_global.reindex', 'transform._types'],
+          Feature: ['features._types', 'indices.get', 'xpack.info'],
+          Features: ['indices.get', 'xpack.info'],
+          Filter: ['_global.termvectors', 'ml._types'],
+          IndexingPressure: ['cluster.stats', 'indices._types', 'nodes._types'],
+          IndexingPressureMemory: [
+            'cluster.stats',
+            'indices._types',
+            'nodes._types'
+          ],
+          Ingest: ['ingest._types', 'nodes._types'],
+          MigrationFeature: [
+            'migration.get_feature_upgrade_status',
+            'migration.post_feature_upgrade'
+          ],
+          Operation: ['_global.mget', '_global.mtermvectors'],
+          Phase: ['ilm._types', 'xpack.usage'],
+          Phases: ['ilm._types', 'xpack.usage'],
+          Pipeline: ['ingest._types', 'logstash._types'],
+          Policy: ['enrich._types', 'ilm._types', 'slm._types'],
+          RequestItem: ['_global.msearch', '_global.msearch_template'],
+          ResponseItem: ['_global.bulk', '_global.mget', '_global.msearch'],
+          RoleMapping: ['security._types', 'xpack.usage'],
+          RuntimeFieldTypes: ['cluster.stats', 'xpack.usage'],
+          ShardsStats: ['indices.field_usage_stats', 'snapshot._types'],
+          ShardStats: ['ccr._types', 'indices.stats'],
+          Source: ['_global.reindex', 'transform._types'],
+          Token: [
+            '_global.termvectors',
+            'security.authenticate',
+            'security.create_service_token',
+            'security.enroll_kibana'
+          ]
+        }
+      }
+    ]
   }
 })

output/schema/schema.json

@@ -24,24 +24,20 @@ import {
 } from './types'
 
 export class Response {
-  /** @codegen_name result */
-  body: ResponseBody
-}
-
-/** @variants container */
-export class ResponseBody {
-  /**
-   * Evaluation results for a classification analysis.
-   * It outputs a prediction that identifies to which of the classes each document belongs.
-   */
-  classification?: DataframeClassificationSummary
-  /**
-   * Evaluation results for an outlier detection analysis.
-   * It outputs the probability that each document is an outlier.
-   */
-  outlier_detection?: DataframeOutlierDetectionSummary
-  /**
-   * Evaluation results for a regression analysis which outputs a prediction of values.
-   */
-  regression?: DataframeRegressionSummary
+  body: {
+    /**
+     * Evaluation results for a classification analysis.
+     * It outputs a prediction that identifies to which of the classes each document belongs.
+     */
+    classification?: DataframeClassificationSummary
+    /**
+     * Evaluation results for an outlier detection analysis.
+     * It outputs the probability that each document is an outlier.
+     */
+    outlier_detection?: DataframeOutlierDetectionSummary
+    /**
+     * Evaluation results for a regression analysis which outputs a prediction of values.
+     */
+    regression?: DataframeRegressionSummary
+  }
 }

output/schema/validation-errors.json

@@ -9,13 +9,14 @@ It is configured [in the specification directory](../specification/eslint.config
 |---------------------------------------| - |
 | `single-key-dictionary-key-is-string` | `SingleKeyDictionary` keys must be strings. |
 | `dictionary-key-is-string`            | `Dictionary` keys must be strings. |
-| `no-native-types`                     | TypeScript native utility types (`Record`, `Partial`, etc.) and collection types (`Map`, `Set`, etc.) are not allowed. Use spec-defined aliases like `Dictionary` instead. |
+| `no-native-types`                     | `Typescript native types not allowed, use aliases. |
 | `invalid-node-types`                  | The spec uses a subset of TypeScript, so some types, clauses and expressions are not allowed. |
 | `no-generic-number`                   | Generic `number` type is not allowed outside of `_types/Numeric.ts`. Use concrete numeric types like `integer`, `long`, `float`, `double`, etc. |
 | `request-must-have-urls`              | All Request interfaces extending `RequestBase` must have a `urls` property defining their endpoint paths and HTTP methods. |
 | `no-variants-on-responses`            | `@variants` is only supported on Interface types, not on Request or Response classes. Use value_body pattern with `@codegen_name` instead. |
 | `no-inline-unions`                    | Inline union types (e.g., `field: A \| B`) are not allowed in properties/fields. Define a named type alias instead to improve code generation for statically-typed languages. |
 | `prefer-tagged-variants`              | Union of class types should use tagged variants (`@variants internal` or `@variants container`) instead of inline unions for better deserialization support in statically-typed languages. |
+| `no-duplicate-type-names`             | All types must be unique across class and enum definitions.                                                                                                                                |
 
 ## Usage