Skip to content

Commit 97fbbca

Browse files
committed
Ignore errors from private APIs
1 parent e3a6119 commit 97fbbca

File tree

2 files changed

+7
-60
lines changed

2 files changed

+7
-60
lines changed

compiler/src/steps/validate-model.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@ enum JsonEvent {
3737
array = 'array'
3838
}
3939

40+
const privateNamespaces = ['_internal', 'profiling']
41+
4042
/**
4143
* Validates the internal consistency of the model (doesn't check the json spec)
4244
*
@@ -208,6 +210,11 @@ export default async function validateModel (apiModel: model.Model, restSpec: Ma
208210
function validateEndpoint (endpoint: model.Endpoint): void {
209211
setRootContext(endpoint.name, 'request')
210212

213+
// Skip validation for internal endpoints
214+
if (privateNamespaces.some(ns => endpoint.name.startsWith(ns))) {
215+
return
216+
}
217+
211218
if (endpoint.request == null) {
212219
if (endpoint.response == null) {
213220
modelError('Missing request & response')

output/schema/validation-errors.json

Lines changed: 0 additions & 60 deletions
Original file line numberDiff line numberDiff line change
@@ -1,41 +1,5 @@
11
{
22
"endpointErrors": {
3-
"_internal.delete_desired_balance": {
4-
"request": [
5-
"Missing request & response"
6-
],
7-
"response": []
8-
},
9-
"_internal.delete_desired_nodes": {
10-
"request": [
11-
"Missing request & response"
12-
],
13-
"response": []
14-
},
15-
"_internal.get_desired_balance": {
16-
"request": [
17-
"Missing request & response"
18-
],
19-
"response": []
20-
},
21-
"_internal.get_desired_nodes": {
22-
"request": [
23-
"Missing request & response"
24-
],
25-
"response": []
26-
},
27-
"_internal.prevalidate_node_removal": {
28-
"request": [
29-
"Missing request & response"
30-
],
31-
"response": []
32-
},
33-
"_internal.update_desired_nodes": {
34-
"request": [
35-
"Missing request & response"
36-
],
37-
"response": []
38-
},
393
"async_search.submit": {
404
"request": [
415
"interface definition _types:QueryVectorBuilder - Property text_embedding is a single-variant and must be required"
@@ -291,30 +255,6 @@
291255
],
292256
"response": []
293257
},
294-
"profiling.flamegraph": {
295-
"request": [
296-
"Missing request & response"
297-
],
298-
"response": []
299-
},
300-
"profiling.stacktraces": {
301-
"request": [
302-
"Missing request & response"
303-
],
304-
"response": []
305-
},
306-
"profiling.status": {
307-
"request": [
308-
"Missing request & response"
309-
],
310-
"response": []
311-
},
312-
"profiling.topn_functions": {
313-
"request": [
314-
"Missing request & response"
315-
],
316-
"response": []
317-
},
318258
"reindex": {
319259
"request": [
320260
"Request: query parameter 'require_alias' does not exist in the json spec",

0 commit comments

Comments
 (0)