Stop reporting missing endpoints as errors (#4031)

We have other ways of identifying them.

(cherry picked from commit f7edcb5)

Author: pquentin

compiler/src/steps/validate-model.ts

@@ -215,14 +215,7 @@ export default async function validateModel (apiModel: model.Model, restSpec: Ma
       return
     }
 
-    if (endpoint.request == null) {
-      if (endpoint.response == null) {
-        modelError('Missing request & response')
-        return
-      } else {
-        modelError('Missing request')
-      }
-    } else {
+    if (endpoint.request !== null) {
       const reqType = getTypeDef(endpoint.request)
 
       if (reqType == null) {
@@ -266,9 +259,7 @@ export default async function validateModel (apiModel: model.Model, restSpec: Ma
 
     setRootContext(endpoint.name, 'response')
 
-    if (endpoint.response == null) {
-      modelError('Missing response')
-    } else {
+    if (endpoint.response !== null) {
       const respType = getTypeDef(endpoint.response)
 
       if (respType == null) {

output/schema/validation-errors.json

@@ -6,12 +6,6 @@
       ],
       "response": []
     },
-    "capabilities": {
-      "request": [
-        "Missing request & response"
-      ],
-      "response": []
-    },
     "cluster.get_component_template": {
       "request": [
         "Request: query parameter 'flat_settings' does not exist in the json spec"
@@ -24,30 +18,6 @@
       ],
       "response": []
     },
-    "connector.secret_delete": {
-      "request": [
-        "Missing request & response"
-      ],
-      "response": []
-    },
-    "connector.secret_get": {
-      "request": [
-        "Missing request & response"
-      ],
-      "response": []
-    },
-    "connector.secret_post": {
-      "request": [
-        "Missing request & response"
-      ],
-      "response": []
-    },
-    "connector.secret_put": {
-      "request": [
-        "Missing request & response"
-      ],
-      "response": []
-    },
     "create": {
       "request": [
         "Request: query parameter 'if_primary_term' does not exist in the json spec",
@@ -74,24 +44,6 @@
       ],
       "response": []
     },
-    "fleet.delete_secret": {
-      "request": [
-        "Missing request & response"
-      ],
-      "response": []
-    },
-    "fleet.get_secret": {
-      "request": [
-        "Missing request & response"
-      ],
-      "response": []
-    },
-    "fleet.post_secret": {
-      "request": [
-        "Missing request & response"
-      ],
-      "response": []
-    },
     "get_source": {
       "request": [
         "Request: query parameter 'stored_fields' does not exist in the json spec"
@@ -198,12 +150,6 @@
       ],
       "response": []
     },
-    "transform.get_node_stats": {
-      "request": [
-        "Missing request & response"
-      ],
-      "response": []
-    },
     "transform.get_transform": {
       "request": [],
       "response": [