Merge remote-tracking branch 'origin/main' into kibana-endpoint

Author: pquentin

.backportrc.json

@@ -0,0 +1,6 @@
+{
+  "repoOwner": "elastic",
+  "repoName": "elasticsearch-specification",
+  "targetBranchChoices": ["9.0", "8.19", "8.18", "8.17"],
+  "fork": false
+}

.buildkite/kibana.sh

@@ -5,15 +5,21 @@ set -euo pipefail
 # Since we're into the current repo, move to the top-level
 cd ..
 
+echo "--- Install dependencies"
+lsb_release -a
+apt-get update -y
+apt-get install -y unzip
+
 echo "--- Clone elasticsearch-js"
 git clone -v -- [email protected]:elastic/elasticsearch-js.git
-pushd elasticsearch-js
-git checkout $BUILDKITE_BRANCH
-popd
+
+echo "--- Clone elastic-client-generator-js"
+git clone -v -- [email protected]:elastic/elastic-client-generator-js.git
+mkdir elastic-client-generator-js/output
 
 echo "--- Clone Kibana"
 git clone -v --reference /usr/local/git-references/git-github-com-elastic-kibana-git -- [email protected]:elastic/kibana.git
-cd kibana
+pushd kibana
 
 echo "--- Install Node.js and Yarn"
 curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.1/install.sh | bash
@@ -25,13 +31,17 @@ set -e
 nvm install
 nvm use
 npm install --global yarn
+popd
 
 echo "--- Install elasticsearch-js"
-pushd ../elasticsearch-js
+pushd elasticsearch-js
 npm install
+node .buildkite/make.mjs --task codegen main
 npm run build
 npm pack
 popd
+
+pushd kibana
 yarn add ../elasticsearch-js/elastic-elasticsearch-*.tgz
 
 echo "--- Bootstrap Kibana"

.buildkite/kibana.yml

@@ -3,7 +3,6 @@ agents:
   cpu: "4"
   ephemeralStorage: 15Gi
 
-
 steps:
   - label: "Run Kibana type checks"
     command: .buildkite/kibana.sh

.gitattributes

@@ -234,5 +234,6 @@ dist/*            binary
 
 output/** linguist-generated=true
 output/schema/validation-errors.json linguist-generated=false
+compiler-rs/compiler-wasm-lib/pkg/* linguist-generated=true
 
 ####################################################################################################

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,18 +1 @@
-<!--
-
-Hello there!
-
-Thank you for opening a pull request!
-Please make sure to follow the steps below when opening a pr:
-
-- Sign the CLA https://www.elastic.co/contributor-agreement/
-- Tag the relative issue (if any) and give a brief explanation on what your changes are doing
-- If you did a spec change, remember to generate again the outputs, you can do it by running `make contrib`
-- Add the appropriate backport labels. If you need to backport a breaking change (e.g. changing the structure of a type or changing the type/optionality of a field), please follow these rules:
-  - If the API is unusable without the change -> every supported version
-  - If the API is usable, but fix is on the response side -> every supported version
-  - If the API is usable, but fix is on the request side -> no backport, unless the API is _partially_ usable and the fix unlocks a missing feature that has no workaround
-
-Happy coding!
-
--->
+<!-- Hello there! Thank you for opening a pull request. See CONTRIBUTING.md for instructions. -->

.github/download-artifacts/index.js

@@ -17,23 +17,23 @@
  * under the License.
  */
 
-'use strict'
-
-const core = require('@actions/core')
-const { join } = require('path')
-const minimist = require('minimist')
-const stream = require('stream')
-const { promisify } = require('util')
-const { createWriteStream, promises } = require('fs')
-const rimraf = require('rimraf')
-const fetch = require('node-fetch')
-const crossZip = require('cross-zip')
+import core from '@actions/core'
+import { join, dirname } from 'path'
+import { fileURLToPath } from 'url'
+import minimist from 'minimist'
+import stream from 'stream'
+import { promisify } from 'util'
+import { createWriteStream, promises } from 'fs'
+import { rimraf } from 'rimraf'
+import fetch from 'node-fetch'
+import crossZip from 'cross-zip'
 
 const { mkdir, rename, readdir, unlink } = promises
 const pipeline = promisify(stream.pipeline)
 const unzip = promisify(crossZip.unzip)
-const rm = promisify(rimraf)
 
+const __filename = fileURLToPath(import.meta.url)
+const __dirname = dirname(__filename)
 const esFolder = join(__dirname, '..', '..', 'artifacts')
 const zipFolder = join(esFolder, 'artifacts.zip')
 const downloadedSpec = join(esFolder, 'rest-api-spec', 'api')
@@ -57,8 +57,8 @@ async function downloadArtifacts (opts) {
   core.info(`Resolved artifact URL for ${resolved.commit_url}`)
 
   core.info('Cleanup')
-  await rm(esFolder)
-  await rm(specFolder)
+  await rimraf(esFolder)
+  await rimraf(specFolder)
   await mkdir(esFolder, { recursive: true })
   await mkdir(specFolder, { recursive: true })
 
@@ -74,7 +74,7 @@ async function downloadArtifacts (opts) {
   await unzip(zipFolder, esFolder)
 
   core.info('Cleanup')
-  await rm(zipFolder)
+  await rimraf(zipFolder)
 
   core.info('Moving files')
   const files = await readdir(downloadedSpec)

.github/download-artifacts/package.json

@@ -2,6 +2,7 @@
   "name": "download-artifacts",
   "version": "1.0.0",
   "description": "",
+  "type": "module",
   "main": "index.js",
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1"
@@ -13,7 +14,7 @@
     "@actions/core": "^1.6.0",
     "cross-zip": "^4.0.0",
     "minimist": "^1.2.5",
-    "node-fetch": "^2.6.7",
-    "rimraf": "^3.0.2"
+    "node-fetch": "^3",
+    "rimraf": "^6"
   }
 }

.github/validate-pr/index.js

@@ -26,7 +26,7 @@ import assert from 'assert'
 import * as core from '@actions/core'
 import { copyFile } from 'fs/promises'
 import * as github from '@actions/github'
-import specification from '../../output/schema/schema.json' assert { type: 'json' }
+import specification from '../../output/schema/schema.json' with { type: 'json' }
 import { run as getReport } from '../../../clients-flight-recorder/scripts/types-validator/index.js'
 import {
   getNamespace,
@@ -90,7 +90,12 @@ async function run() {
     if (file.startsWith('specification/_spec_utils')) continue
     if (file.startsWith('specification/_doc_ids')) continue
     if (file.startsWith('specification/_json_spec')) continue
-    if (file === 'specification/tsconfig.json') continue
+    if (file.startsWith('specification/node_modules')) continue
+    if (file.endsWith('tsconfig.json')) continue
+    if (file.endsWith('eslint.config.js')) continue
+    if (file.endsWith('package.json')) continue
+    if (file.endsWith('package-lock.json')) continue
+    if (file.endsWith('.md')) continue
     if (getApi(file).endsWith('_types')) {
       const apis = specification.endpoints
         .filter(endpoint => endpoint.name.split('.').filter(s => !privateNames.includes(s))[0] === getApi(file).split('.')[0])

.github/validate-pr/package.json

@@ -13,6 +13,6 @@
   "dependencies": {
     "@actions/core": "^1.6.0",
     "@actions/github": "^5.0.0",
-    "zx": "^4.3.0"
+    "zx": "^8"
   }
 }

.github/workflows/code-format.yml

@@ -10,10 +10,10 @@ jobs:
     steps:
     - uses: actions/checkout@v4
 
-    - name: Use Node.js 20
+    - name: Use Node.js 22
       uses: actions/setup-node@v4
       with:
-        node-version: 20
+        node-version: 22
 
     - name: Install
       run: |