Skip to content

Commit e86ebc9

Browse files
committed
code review feedback
1 parent 43e6fa1 commit e86ebc9

File tree

3 files changed

+16
-16
lines changed

3 files changed

+16
-16
lines changed

output/schema/schema.json

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

output/typescript/types.ts

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

specification/simulate/ingest/SimulateIngestResponse.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,11 @@ import { Id, IndexName, VersionNumber } from '@_types/common'
2525
import { ErrorCause } from '@_types/Errors'
2626

2727
export class Response {
28-
body: { docs: SimulateDocumentResult[] }
28+
body: { docs: SimulateIngestDocumentResult[] }
2929
}
3030

31-
export class SimulateDocumentResult {
32-
doc?: DocumentSimulation
31+
export class SimulateIngestDocumentResult {
32+
doc?: IngestDocumentSimulation
3333
/**
3434
* Any error resulting from simulatng ingest on this doc. This can be an error generated by
3535
* executing a processor, or a mapping validation error when simulating indexing the resulting
@@ -46,7 +46,7 @@ export class SimulateDocumentResult {
4646
*
4747
* @behavior_meta AdditionalProperties fieldname=metadata description="Additional metadata"
4848
*/
49-
export class DocumentSimulation
49+
export class IngestDocumentSimulation
5050
implements AdditionalProperties<string, string>
5151
{
5252
/**
@@ -64,7 +64,7 @@ export class DocumentSimulation
6464
/**
6565
*
6666
*/
67-
_version?: Stringified<VersionNumber>
67+
_version: Stringified<VersionNumber>
6868
/**
6969
* A list of the names of the pipelines executed on this document.
7070
*/

0 commit comments

Comments
 (0)