Compiler: late sync endpoints availability from json-spec (#5432) (#5839)

* Compiler: sync endpoints json-spec availability only if typescript has none.

* linter fixes

---------


(cherry picked from commit eca6d46)

Co-authored-by: Laurent Saint-Félix <[email protected]>
Co-authored-by: Josh Mock <[email protected]>

Author: 3 people

compiler/src/compiler.ts

@@ -21,7 +21,11 @@ import { writeFile, mkdir } from 'fs/promises'
 import { join } from 'path'
 import stringify from 'safe-stable-stringify'
 import { Model } from './model/metamodel'
-import { compileEndpoints, compileSpecification } from './model/build-model'
+import {
+  compileEndpoints,
+  compileSpecification,
+  reAddAvailability
+} from './model/build-model'
 import buildJsonSpec, { JsonSpec } from './model/json-spec'
 import { ValidationErrors } from './validation-errors'
 
@@ -54,6 +58,7 @@ export default class Compiler {
     this.jsonSpec = buildJsonSpec()
     const endpoints = compileEndpoints()
     this.model = compileSpecification(endpoints, this.specsFolder, this.outputFolder)
+    this.model = reAddAvailability(this.model) // resync availability information based on json spec if typescript has none.
     return this
   }
 

compiler/src/model/build-model.ts

@@ -59,6 +59,24 @@ import {
 
 const jsonSpec = buildJsonSpec()
 
+export function reAddAvailability (model: model.Model): model.Model {
+  for (const [api, spec] of jsonSpec.entries()) {
+    for (const endpoint of model.endpoints) {
+      if (endpoint.name === api) {
+        if ((spec.stability != null || spec.visibility != null) && (endpoint.availability.stack === undefined && endpoint.availability.serverless === undefined)) {
+          endpoint.availability = {
+            stack: {
+              stability: spec.stability,
+              visibility: spec.visibility
+            }
+          }
+        }
+      }
+    }
+  }
+  return model
+}
+
 export function compileEndpoints (): Record<string, model.Endpoint> {
   // Create endpoints and merge them with
   // the recorded mappings if present.
@@ -73,12 +91,7 @@ export function compileEndpoints (): Record<string, model.Endpoint> {
       // Setting these values by default should be removed
       // when we no longer use rest-api-spec stubs as the
       // source of truth for stability/visibility.
-      availability: {
-        stack: {
-          stability: spec.stability,
-          visibility: spec.visibility
-        }
-      },
+      availability: {},
       request: null,
       requestBodyRequired: Boolean(spec.body?.required),
       response: null,
@@ -91,7 +104,7 @@ export function compileEndpoints (): Record<string, model.Endpoint> {
       })
     }
     if (typeof spec.feature_flag === 'string') {
-      map[api].availability.stack.featureFlag = spec.feature_flag
+      map[api].availability.stack = { featureFlag: spec.feature_flag }
     }
   }
   return map