Fix additional property name for TermsQuery
#3038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I'm not using the key and value names, just their types, so for the Python DSL client this is fine 👍 |
Anaethelion
approved these changes
Oct 22, 2024
Member
|
|
picandocodigo
approved these changes
Oct 22, 2024
Contributor
|
It's not implemented yet in the Java generator, so no problem. |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 23, 2024
(cherry picked from commit 16130b9)
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.16 8.16
# Navigate to the new working tree
cd .worktrees/backport-8.16
# Create a new branch
git switch --create backport-3038-to-8.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 16130b9a2f165a445d3201043ea47278eed1c164
# Push it to GitHub
git push --set-upstream origin backport-3038-to-8.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.16Then, create a pull request where the |
flobernd
added a commit
that referenced
this pull request
Oct 23, 2024
(cherry picked from commit 16130b9) Co-authored-by: Florian Bernd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be a copy/paste mistake made by me when I implemented the
behavior_metatag.@swallez @Anaethelion @ezimuel @picandocodigo @miguelgrinberg @l-trotta @pquentin @JoshMock Please check, if this is a breaking change in any of your clients. Most likely only the static language clients should be affected - if at all.