Adding new URL params to Connector API endpoints + new type to Connector types #3549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
pquentin
reviewed
Jan 20, 2025
| api_key_secret_id?: string | ||
| configuration: ConnectorConfiguration | ||
| custom_scheduling: ConnectorCustomScheduling | ||
| deleted?: boolean |
There was a problem hiding this comment.
Reading elastic/elasticsearch#118669 it looks like deleted is always set.
Suggested change
| deleted?: boolean | |
| deleted: boolean |
Comment on lines
52
to
55
| /** | ||
| * A flag indicating if the connector should be hard deleted. Defaults to false. | ||
| */ | ||
| hard?: boolean |
There was a problem hiding this comment.
We have specific syntax for default values:
Suggested change
| /** | |
| * A flag indicating if the connector should be hard deleted. Defaults to false. | |
| */ | |
| hard?: boolean | |
| /** | |
| * A flag indicating if the connector should be hard deleted. | |
| * @server_default false | |
| */ | |
| hard?: boolean |
Comment on lines
44
to
49
| query_parameters: { | ||
| /** | ||
| * A flag to indicate if the desired connector should be fetched even if it was soft-deleted | ||
| */ | ||
| include_deleted?: boolean | ||
| } |
There was a problem hiding this comment.
Suggested change
| query_parameters: { | |
| /** | |
| * A flag to indicate if the desired connector should be fetched even if it was soft-deleted | |
| */ | |
| include_deleted?: boolean | |
| } | |
| query_parameters: { | |
| /** | |
| * A flag to indicate if the desired connector should be fetched even if it was soft-deleted | |
| * @server_default false | |
| */ | |
| include_deleted?: boolean | |
| } |
Comment on lines
60
to
63
| /** | ||
| * A flag to indicate if the desired connector should be fetched even if it was solf-deleted" | ||
| */ | ||
| include_deleted?: boolean |
There was a problem hiding this comment.
Suggested change
| /** | |
| * A flag to indicate if the desired connector should be fetched even if it was solf-deleted" | |
| */ | |
| include_deleted?: boolean | |
| /** | |
| * A flag to indicate if the desired connector should be fetched even if it was solf-deleted" | |
| * @server_default false | |
| */ | |
| include_deleted?: boolean |
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new URL param
include_deletedtoconnector.getconnector.listAlso adding new URL param
hardtoconnector.deleteAnd finally, a new boolean value
deletedto theconnectortypeLink to issue thread can be found here!