Add include_source_on_error to bulk API #3691
Conversation
|
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
|
why is this not automated @pquentin ? We can't expect to ever keep this up to date in so many different places |
|
I don't think is is a feasible path forward |
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
|
We discussed this offline - the long-term plan is that the specification is the source of truth, which means that, yes, for now, we need to port changes from the rest-api-spec. |
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
* Add include_source_on_error to bulk API * Add create, index and update (cherry picked from commit 2e5a4ba)
* Add include_source_on_error to bulk API * Add create, index and update (cherry picked from commit 2e5a4ba)
* Add include_source_on_error to bulk API * Add create, index and update (cherry picked from commit 2e5a4ba)
| "description": "True or false if to include the document source in the error message in case of parsing errors.", | ||
| "name": "include_source_on_error", | ||
| "required": false, | ||
| "serverDefault": false, |
There was a problem hiding this comment.
| "serverDefault": false, | |
| "serverDefault": true, |
| "description": "True or false if to include the document source in the error message in case of parsing errors.", | ||
| "name": "include_source_on_error", | ||
| "required": false, | ||
| "serverDefault": false, |
There was a problem hiding this comment.
| "serverDefault": false, | |
| "serverDefault": true, |
| query_parameters: { | ||
| /** | ||
| * True or false if to include the document source in the error message in case of parsing errors. | ||
| * @server_default false |
There was a problem hiding this comment.
| * @server_default false | |
| * @server_default true |
| } | ||
| ], | ||
| "specLocation": "_global/bulk/BulkRequest.ts#L32-L242" | ||
| "specLocation": "_global/bulk/BulkRequest.ts#L32-L247" |
There was a problem hiding this comment.
Is this also updated manually? What is this used for?
|
I only manually updated the specification/ directory, the rest was generated by |
* Add include_source_on_error to bulk API * Add create, index and update (cherry picked from commit 2e5a4ba) Co-authored-by: Quentin Pradet <[email protected]>
* Add include_source_on_error to bulk API * Add create, index and update (cherry picked from commit 2e5a4ba) Co-authored-by: Quentin Pradet <[email protected]>
* Add include_source_on_error to bulk API * Add create, index and update (cherry picked from commit 2e5a4ba) Co-authored-by: Quentin Pradet <[email protected]>
This is essentially #3681 but just for bulk for now. I added the
_json_specchange and ranmake contribto ensure that this was not adding a new validation error.This was added to Elasticsearch in elastic/elasticsearch#120725.