Skip to content

Conversation

@Anaethelion
Copy link
Contributor

Followup to #4189

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
esql.async_query_delete Missing test Missing test
esql.async_query_get Missing test Missing test
esql.async_query_stop Missing test Missing test
esql.async_query Missing test Missing test
esql.query 294/294 Missing test

You can validate these APIs yourself by using the make validate target.

@Anaethelion Anaethelion requested a review from swallez April 9, 2025 14:38
@Anaethelion Anaethelion merged commit 89118f4 into main Apr 9, 2025
9 of 10 checks passed
@Anaethelion Anaethelion deleted the lsf/prefix_duplicates_esql branch April 9, 2025 14:40
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

The backport to 9.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-9.0 9.0
# Navigate to the new working tree
cd .worktrees/backport-9.0
# Create a new branch
git switch --create backport-4245-to-9.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 89118f45698a7edec4d2d274b9d67da08a47a49f
# Push it to GitHub
git push --set-upstream origin backport-4245-to-9.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-9.0

Then, create a pull request where the base branch is 9.0 and the compare/head branch is backport-4245-to-9.0.

github-actions bot pushed a commit that referenced this pull request Apr 9, 2025
Anaethelion added a commit that referenced this pull request Apr 9, 2025
(cherry picked from commit 89118f4)

Co-authored-by: Laurent Saint-Félix <[email protected]>
github-actions bot pushed a commit that referenced this pull request Jul 24, 2025
pquentin pushed a commit that referenced this pull request Jul 24, 2025
(cherry picked from commit 89118f4)

Co-authored-by: Laurent Saint-Félix <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants